Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on Brave News #28086

Closed
SergeyZhukovsky opened this issue Jan 27, 2023 · 2 comments · Fixed by brave/brave-core#16889
Closed

Crash on Brave News #28086

SergeyZhukovsky opened this issue Jan 27, 2023 · 2 comments · Fixed by brave/brave-core#16889
Assignees
Labels
crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include

Comments

@SergeyZhukovsky
Copy link
Member

I found that crash on GPS on 1.47.x. We need to do a check here:
https://github.com/brave/brave-core/blob/1.47.x/android/java/org/chromium/chrome/browser/ntp/BraveNewTabPageLayout.java#L579

To check it, just make sure that you can scroll the news.

Exception java.lang.ArrayIndexOutOfBoundsException: length=1; index=1
  at java.util.concurrent.CopyOnWriteArrayList.get (CopyOnWriteArrayList.java:380)
  at java.util.concurrent.CopyOnWriteArrayList.get (CopyOnWriteArrayList.java:393)
  at org.chromium.chrome.browser.ntp.BraveNewTabPageLayout$4.onScrollStateChanged (BraveNewTabPageLayout.java:579)
  at androidx.recyclerview.widget.RecyclerView.dispatchOnScrollStateChanged (RecyclerView.java:5699)
  at androidx.recyclerview.widget.RecyclerView.setScrollState (RecyclerView.java:1649)
  at androidx.recyclerview.widget.RecyclerView$ViewFlinger.run (RecyclerView.java:5890)
  at android.view.Choreographer$CallbackRecord.run (Choreographer.java:1027)
  at android.view.Choreographer.doCallbacks (Choreographer.java:837)
  at android.view.Choreographer.doFrame (Choreographer.java:763)
  at android.view.Choreographer$FrameDisplayEventReceiver.run (Choreographer.java:999)
  at android.os.Handler.handleCallback (Handler.java:938)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loop (Looper.java:268)
  at android.app.ActivityThread.main (ActivityThread.java:8089)
  at java.lang.reflect.Method.invoke (Method.java)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:626)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:997)
@kjozwiak
Copy link
Member

The above requires 1.47.188 or higher for 1.47.x verification 👍

@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.47.188 Chromium: 109.0.5414.119 (Official Build) (32-bit)
--- | ---
Revision | 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS | Android 13; Build/TQ1A.230105.002
  • ensured that you can opt-in into Brave News via NTP without any issues
  • ensured that you can scroll through the news feed without any issues
  • ensured that tapping on news articles opened without any issues
  • ensured that current position within the news feed is preserved when switching tabs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants