Crash on handling URL

[SergeyZhukovsky]

I found that crash on GPS on 1.47.x. It looks like it's crashing in the upstream but we can do a try catch on our calls to prevent crashing.

To check it, just make sure that you can open links from third party apps when Brave is set as a default browser.

Exception java.lang.RuntimeException:
  at android.app.ActivityThread.performResumeActivity (ActivityThread.java:5365)
  at android.app.ActivityThread.handleResumeActivity (ActivityThread.java:5431)
  at android.app.servertransaction.ResumeActivityItem.execute (ResumeActivityItem.java:54)
  at android.app.servertransaction.ActivityTransactionItem.execute (ActivityTransactionItem.java:45)
  at android.app.servertransaction.TransactionExecutor.executeLifecycleState (TransactionExecutor.java:176)
  at android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:97)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:2571)
  at android.os.Handler.dispatchMessage (Handler.java:106)
  at android.os.Looper.loopOnce (Looper.java:226)
  at android.os.Looper.loop (Looper.java:313)
  at android.app.ActivityThread.main (ActivityThread.java:8741)
  at java.lang.reflect.Method.invoke (Method.java)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:571)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1067)
Caused by java.lang.NullPointerException:
  at org.chromium.chrome.browser.tabmodel.ChromeTabCreator.createNewTab (ChromeTabCreator.java:135)
  at org.chromium.chrome.browser.tabmodel.ChromeTabCreator.launchUrl (ChromeTabCreator.java:312)
  at org.chromium.chrome.browser.tabmodel.ChromeTabCreator.launchUrl (ChromeTabCreator.java:295)
  at org.chromium.chrome.browser.tabmodel.BraveTabCreator.launchUrl (BraveTabCreator.java:61)
  at org.chromium.chrome.browser.app.BraveActivity.openNewOrSelectExistingTab (BraveActivity.java:1455)
  at org.chromium.chrome.browser.app.BraveActivity.onNewIntent (BraveActivity.java:1637)
  at org.chromium.chrome.browser.ChromeTabbedActivity.onNewIntent (ChromeTabbedActivity.java:971)
  at android.app.Activity.performNewIntent (Activity.java:8594)
  at android.app.Instrumentation.callActivityOnNewIntent (Instrumentation.java:1484)
  at android.app.Instrumentation.callActivityOnNewIntent (Instrumentation.java:1497)
  at android.app.ActivityThread.deliverNewIntents (ActivityThread.java:4352)
  at android.app.ActivityThread.performResumeActivity (ActivityThread.java:5331)

[kjozwiak]

The above requires 1.48.152 or higher for 1.48.x verification 👍

[stephendonner]

Verified PASSED using 1.48.152, Chromium 109.0.5414.119 on a Google Pixel XL running Android 9

Open tabs in custom tabs On - PASSED

1. confirmed Open tabs in custom tabs is defaulted to On / Enabled
2. opened the Twitter app
3. tapped on a Tweet
4. tapped on a link

Confirmed it opened in a Brave-browser custom tab (see logo next to Tweet text, below), without crashing

example	example	example	example	example

Open tabs in custom tabs Off - PASSED

1. toggled Open tabs in custom tabs to Off/Disabled
2. opened the Twitter app
3. tapped on a Tweet with a link
4. opened the link

Confirmed it opened in a separate, "full" Brave browser, rather than the "embedded" (custom) one, without any crashes

example	example	example