Crash on rewards site banner

[SergeyZhukovsky]

I found that crash on GPS on 1.47.x. I think we support only portrait orientation in that Activity? Maybe we can support both? Not sure why do we have such limitation there.

To test it just make sure that it's possible to tip a website.

Exception java.lang.RuntimeException: Unable to start activity ComponentInfo{com.brave.browser/org.chromium.chrome.browser.BraveRewardsSiteBannerActivity}: java.lang.IllegalStateException: Only fullscreen opaque activities can request orientation
  at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:2972)
  at android.app.ActivityThread.handleLaunchActivity (ActivityThread.java:3051)
  at android.app.ActivityThread.-wrap11 (ActivityThread.java)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1701)
  at android.os.Handler.dispatchMessage (Handler.java:105)
  at android.os.Looper.loop (Looper.java:164)
  at android.app.ActivityThread.main (ActivityThread.java:6797)
  at java.lang.reflect.Method.invoke (Method.java)
  at com.android.internal.os.Zygote$MethodAndArgsCaller.run (Zygote.java:240)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:772)
Caused by java.lang.IllegalStateException: Only fullscreen opaque activities can request orientation
  at android.app.Activity.onCreate (Activity.java:990)
  at androidx.core.app.ComponentActivity.onCreate (ComponentActivity.java:88)
  at androidx.activity.ComponentActivity.onCreate (ComponentActivity.java:378)
  at androidx.fragment.app.FragmentActivity.onCreate (FragmentActivity.java:217)
  at org.chromium.chrome.browser.BraveRewardsSiteBannerActivity.onCreate (BraveRewardsSiteBannerActivity.java:66)
  at android.app.Activity.performCreate (Activity.java:6989)
  at android.app.Instrumentation.callActivityOnCreate (Instrumentation.java:1235)
  at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:2925)

[deeppandya]

@SergeyZhukovsky we don't have landscape UI for tipping banner. And that's why we only support portrait mode.
CC @Miyayes

[SergeyZhukovsky]

@deeppandya maybe we can prevent from trying to run it when we are in that mode?

[sujitacharya2005]

this issue will fix by this PR : brave/brave-core#17116
This issue is happened in only in Android Oreo
Now this Activity is changed to AsyncInitializationActivity and style to BraveTranslucent which is AppCompat.
We will close this issue for now later version if this exist then we will put alternative fix.

[kjozwiak]

Going to label this once as QA/No as we'll run through rewards via the manual passes which involves tipping so this will get checked by default. CCing @Uni-verse @GeetaSarvadnya to keep an eye when we're running through rewards tipping. Because this was found via the GPS dashboard, there's no exact STR/Cases that can be used.

[SergeyZhukovsky]

That is still an issue, I opened a new issue to track it with steps on how to replicate it
#29562