Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect NFT's are shown when wallet is unlocked #28301

Closed
srirambv opened this issue Feb 6, 2023 · 2 comments · Fixed by brave/brave-core#17638
Closed

Incorrect NFT's are shown when wallet is unlocked #28301

srirambv opened this issue Feb 6, 2023 · 2 comments · Fixed by brave/brave-core#17638
Assignees
@Pavneet-Sing
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Milestone
1.51.x - Release

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 6, 2023

Description

Incorrect NFT's are shown when wallet is unlocked

Steps to reproduce

Not sure

Actual result

Ethereum NFT's are shown under Solana
image

Expected result

Should only list the relevant NFT's when network is changed

Issue reproduces how often

Intermittent

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Maybe
  • Can you reproduce this issue with the current Play Store Nightly version? Maybe

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Tablet
  • Android version: 12

Brave version

1.48.155

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @simoarpe @Pavneet-Sing
@srirambv srirambv added bug release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Feb 6, 2023
This was referenced Feb 6, 2023
Closed
Closed
@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 10, 2023
@Pavneet-Sing Pavneet-Sing self-assigned this Mar 3, 2023
This was referenced Mar 15, 2023
Closed
Merged
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 16, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Apr 13, 2023
Merged
25 tasks
@srirambv srirambv mentioned this issue Apr 17, 2023
Closed
@srirambv
Copy link
Contributor Author

Partially verified as part of #29274 (comment). There is still a race condition when switching quickly causes wrong NFT to show up but should be fixed as part of brave/brave-core#17967. So this needs to be verified again when brave/brave-core#17967 on nightly or when migrates to Beta.

@Pavneet-Sing
Copy link

Partially verified as part of #29274 (comment). There is still a race condition when switching quickly causes wrong NFT to show up but should be fixed as part of brave/brave-core#17967. So this needs to be verified again when brave/brave-core#17967 on nightly or when migrates to Beta.

Race condition is known and should be fixed with #29706 issue.

@kjozwiak kjozwiak mentioned this issue May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.51.x - Release
4 participants
@jamesmudgett @Pavneet-Sing @srirambv @brave-builds