Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several Strings Remain Untranslated #2831

Closed
jonathansampson opened this issue Jan 6, 2019 · 2 comments · Fixed by brave/brave-core#1366
Closed

Several Strings Remain Untranslated #2831

jonathansampson opened this issue Jan 6, 2019 · 2 comments · Fixed by brave/brave-core#1366
Assignees
Labels

Comments

@jonathansampson
Copy link
Contributor

jonathansampson commented Jan 6, 2019

Description

Feedback from a user on Discord regarding French translations. Many strings still fall back to English. Screenshots below.

Brave version (brave://version info)

0.58.18

Reproducible on current release:

Yes

Screenshots

Shown below:

  • New tab
  • New Window
  • New private window
  • New private window with Tor
  • Favoris (child menu)
    • Bookmark this page
    • Bookmark open pages
    • Show bookmarks bar
    • Bookmark manager
    • Import bookmarks and settings…
    • Imported From Firefox (label suggested by Brave)
  • Zoom
  • Find
  • More tools
    • Save page as…
    • Create shortcut…
    • Clear browsing data…
    • Extensions
    • Task manager
    • Developer tools
  • Modifier
    • Cut
    • Copy
    • Paste
  • About Brave
  • (Context menu on tab)
    • New Tab
    • Pin tab
    • Mute site
    • Close tab
    • Close other tabs
    • Close tabs to the right
    • Reopen closed tab
    • Bookmark all tabs…
  • (Context menu on dashboard)
    • Back
    • Forward
    • Reload
    • Save as…
    • Print…
    • Brave
    • View page source
    • Inspect
  • (Context menu on image link)
    • Open link in new tab
    • Open link in new window
    • Open link in private window
    • Open link in private window with Tor
    • Save link as…
    • Copy link address
    • Open image in new tab
    • Save image as…
    • Copy image
    • Copy image address
    • Search Google for image
    • Brave
    • Inspect
  • (Site Shields)
    • Shields UP|DOWN for this site
    • If a site appears broken, try shields down
    • `# Total Blocked
    • Ads and trackers blocked
    • Connections encrypted
    • 3rd-party cookies blocked
    • All scripts allowed
    • 3rd-party device recognition blocked
    • Global shield defaults

image

@bbondy bbondy added this to the 1.x Backlog milestone Jan 13, 2019
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 15, 2019
@bbondy bbondy modified the milestones: 1.x Backlog, 0.59.x - Beta Jan 17, 2019
@bbondy bbondy added the QA/Yes label Jan 17, 2019
@bbondy
Copy link
Member

bbondy commented Jan 17, 2019

QA notes, you can use the hamburger menu:

Old:
capture d ecran le 2019-01-17 a 17 02 40

All of those english strings will be translated now.

@btlechowski
Copy link

btlechowski commented Jan 23, 2019

Verification passed on

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Windows

Shields panel is not translated. Logged #3064

[PASS] Hamburger Menu
image

[PASS] Context menu on tab
image

[PASS] Context menu on dashboard
image

[PASS] Context menu on image link
image

Verified passed with

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Mac OS X

Hamburger menu PASSED
screen shot 2019-01-24 at 14 12 44
screen shot 2019-01-24 at 14 12 52
screen shot 2019-01-24 at 14 12 59
screen shot 2019-01-24 at 14 13 09

Context menu on tab PASSED
screen shot 2019-01-24 at 14 16 22

Context menu on dashboard PASSED
screen shot 2019-01-24 at 14 17 15

Context menu on image PASSED
screen shot 2019-01-24 at 14 18 17

Shields panel did not pass, comment added on #3064

Verification passed on

Brave 0.59.30 Chromium: 72.0.3626.71 (Build officiel) (64 bits)
Révision f52ccad2a6a3c65fc9e0c591a517ceab1198dac0-refs/branch-heads/3626@{#763}
Système d'exploitation Linux

capture d ecran de 2019-01-28 01-05-42
capture d ecran de 2019-01-28 01-05-54
capture d ecran de 2019-01-28 01-06-00
capture d ecran de 2019-01-28 01-06-15
capture d ecran de 2019-01-28 01-06-18
capture d ecran de 2019-01-28 01-06-20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants