Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computer name is missing in Let’s sync a new device with “”. (Follow up of #2728) #2839

Closed
GeetaSarvadnya opened this issue Jan 7, 2019 · 5 comments

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 7, 2019

Description

Computer name is missing in Let’s sync a new device with “”.

Devices

Device 1: Windows 10 x64 (0.60.6 dev build)
Device 2: Android Samsung Galaxy 5.1 (1.0.72 (sync1))

Steps to Reproduce

  1. Clean install 0.60.6
  2. Sync Windows and Android devices through QR code
  3. Once sync is established between two devices leave the sync chain on Windows
  4. Click on Start new sync chain.

Actual result:

image
computer name missing - 0 60 6

Expected result:

image

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.60.6 Chromium: 72.0.3626.28 (Official Build) dev (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows

Reproducible on current release: NO

  • Does it reproduce on brave-browser dev/beta builds? reproducible only Dev not on Beta

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional Information

Could be merge issue PR 1191 says it's already merged to dev channel. Also, before the version bump 0.60.6, PR 1191 commit is available.

@brave/legacy_qa

@srirambv
Copy link
Contributor

@GeetaSarvadnya could you please retest this on current beta build and see if it reproduces?

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Jan 18, 2019

@srirambv Now there is no computer name display on Start new sync chain popup, due to UI description change. Not able to reproduce the issue on both Beta (0.59.25) and Dev (0.60.15) builds.

@srirambv
Copy link
Contributor

@cezaraugusto this is fixed as part of the brave/brave-core#1193?

@kjozwiak
Copy link
Member

Where was this fixed @cezaraugusto? We'll need to stick it into the correct milestone as it's closed but still in the 1.x Backlog. Assuming this was changed in 0.59.x with the UI redesign?

@srirambv srirambv modified the milestones: 1.x Backlog, 0.59.x - Release Jan 29, 2019
@srirambv
Copy link
Contributor

Marking as 0.59.x the new UI flow fixed the issue which should be part of general sync flow test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants