Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync string update #2842

Closed
rossmoody opened this issue Jan 7, 2019 · 3 comments
Closed

Sync string update #2842

rossmoody opened this issue Jan 7, 2019 · 3 comments

Comments

@rossmoody
Copy link
Contributor

Need to update the body copy in the modal for "I have a sync code". Should read: Type your supplied sync chain code words into the form below.

image

@LaurenWags
Copy link
Member

@rossmoody - just to confirm, is the only string updated the one from the description? If there are others, can you add a test plan so we know which ones changed?

@rossmoody
Copy link
Contributor Author

Yeah, just the description update, and it's not a change, just a string we missed copying over to match the spec during the locale migration from Brave UI. Here's the spec to check against: https://docs.google.com/document/d/1gvOwHRORwg3xDQEUsWRp_WgYC0_TYc87By8v8r0isYM/edit

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 17, 2019

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows 10
  • Verified the updated description Type your supplied sync chain code words into the form below display in Enter a sync code popup

image

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Linux

image

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Mac OS X

screen shot 2019-01-23 at 4 38 27 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment