Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in Welcome Onboarding #28458

Closed
SergeyZhukovsky opened this issue Feb 12, 2023 · 1 comment · Fixed by brave/brave-core#17201
Closed

Crash in Welcome Onboarding #28458

SergeyZhukovsky opened this issue Feb 12, 2023 · 1 comment · Fixed by brave/brave-core#17201
Assignees
Labels
crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include

Comments

@SergeyZhukovsky
Copy link
Member

I found that crash in GPS in 1.48.160. We need to fix and uplift to a stable channel.

Exception java.lang.RuntimeException: Unable to resume activity {com.brave.browser/org.chromium.chrome.browser.firstrun.WelcomeOnboardingActivity}: java.lang.RuntimeException: Failure delivering result ResultInfo{who=null, request=37, result=-1, data=null} to activity {com.brave.browser/org.chromium.chrome.browser.firstrun.WelcomeOnboardingActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'android.view.ViewPropertyAnimator android.view.View.animate()' on a null object reference
  at android.app.ActivityThread.performResumeActivity (ActivityThread.java:4501)
  at android.app.ActivityThread.handleResumeActivity (ActivityThread.java:4533)
  at android.app.servertransaction.ResumeActivityItem.execute (ResumeActivityItem.java:52)
  at android.app.servertransaction.TransactionExecutor.executeLifecycleState (TransactionExecutor.java:176)
  at android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:97)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:2120)
  at android.os.Handler.dispatchMessage (Handler.java:106)
  at android.os.Looper.loop (Looper.java:223)
  at android.app.ActivityThread.main (ActivityThread.java:7785)
  at java.lang.reflect.Method.invoke (Method.java)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:612)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:997)
Caused by java.lang.RuntimeException: Failure delivering result ResultInfo{who=null, request=37, result=-1, data=null} to activity {com.brave.browser/org.chromium.chrome.browser.firstrun.WelcomeOnboardingActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'android.view.ViewPropertyAnimator android.view.View.animate()' on a null object reference
  at android.app.ActivityThread.deliverResults (ActivityThread.java:5102)
  at android.app.ActivityThread.performResumeActivity (ActivityThread.java:4488)
Caused by java.lang.NullPointerException: Attempt to invoke virtual method 'android.view.ViewPropertyAnimator android.view.View.animate()' on a null object reference
  at org.chromium.chrome.browser.firstrun.WelcomeOnboardingActivity.setFadeInAnimation (WelcomeOnboardingActivity.java:285)
  at org.chromium.chrome.browser.firstrun.WelcomeOnboardingActivity.nextOnboardingStep (WelcomeOnboardingActivity.java:170)
  at org.chromium.chrome.browser.firstrun.WelcomeOnboardingActivity.onActivityResult (WelcomeOnboardingActivity.java:322)
  at android.app.Activity.dispatchActivityResult (Activity.java:8360)
  at android.app.ActivityThread.deliverResults (ActivityThread.java:5095)
@kjozwiak
Copy link
Member

Going to label this as QA/No as this will get checked by default when we're running through the reduced manual passes for the 1.48.x maintenance release. CCing @Uni-verse @srirambv just in case to keep an eye when running through onboarding when launching Brave for the first time when 1.48.x RC builds come available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants