Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ads box on Rewards Settings page should use disabled content from new design #2846

Closed
ryanml opened this issue Jan 8, 2019 · 0 comments · Fixed by brave/brave-core#1283
Closed

Ads box on Rewards Settings page should use disabled content from new design #2846

ryanml opened this issue Jan 8, 2019 · 0 comments · Fixed by brave/brave-core#1283
Assignees
@ryanml
Labels
feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Milestone
0.60.x - Release ...

Comments

@ryanml
Copy link
Contributor

ryanml commented Jan 8, 2019

Design pictured here:
screen shot 2019-01-07 at 11 14 13 pm
@ryanml ryanml self-assigned this Jan 8, 2019
@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 8, 2019
@mandar-brave mandar-brave added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 8, 2019
@ryanml ryanml mentioned this issue Jan 8, 2019
Merged
9 tasks
@ryanml ryanml mentioned this issue Jan 10, 2019
Merged
18 tasks
@ryanml ryanml mentioned this issue Jan 10, 2019
Merged
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.60.x - Dev Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Projects
None yet
Milestone
0.60.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Updates ads disabled content, bumps brave-ui ryanml/brave-core
4 participants
@rebron @ryanml @NejcZdovc @mandar-brave