"Uncaught ReferenceError: brave_new_tab is not defined" when opening new tab

[ignatiusreza]

Description

The following error will be raised on opening a new tab:

Uncaught ReferenceError: brave_new_tab is not defined
    at <anonymous>:1:1

Steps to Reproduce

1. Open new-tab
2. Open developer console
3. See that Uncaught ReferenceError: brave_new_tab is not defined is logged

Actual result:

Error are raised:

Expected result:

No error raised

Reproduces how often:

Every time

Brave version (brave://version info)

key	value
Brave	0.58.18 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision	15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS	Linux

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?

  not sure...

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?

  since it's on a new tab, Brave Shields is not active yet..

• Is the issue reproducible on the latest version of Chrome?

  nope, since it's Brave specific code

Additional Information

I think the code which raised are on this line: https://github.com/brave/brave-core/blob/0.58.x/browser/ui/webui/brave_new_tab_ui.cc#L114 .. i'm cloning the repo and will try to investigate, but not really sure on where to start.. 😅

[dminca]

Happends to me as well

key	value
Brave	0.62.25 Chromium: 73.0.3683.67 (Official Build) beta (64-bit)
Revision	a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}
OS	Linux

And the error can be spotted on /var/log/syslog as well:

│Mar 12 07:30:08 Homestation org.gnome.SettingsDaemon.MediaKeys-pantheon.desktop[1416]: [1944:1944:0312/073008.385805:ERROR:CONSOLE(1)] "Uncaught ReferenceError: brave_new_tab is not defined", source: chrome://newtab/ (1)                                                  │
│Mar 12 07:30:10 Homestation org.gnome.SettingsDaemon.MediaKeys-pantheon.desktop[1416]: [1944:1944:0312/073010.037016:ERROR:CONSOLE(1)] "Active tab not found", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js (1)                        │
│Mar 12 07:30:10 Homestation org.gnome.SettingsDaemon.MediaKeys-pantheon.desktop[1416]: [1944:1944:0312/073010.041347:ERROR:CONSOLE(1)] "Active tab not found", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js (1)

[caspertone2003]

Happens to me as well.
0.62.27
Windows 10

[delete this: I believe it is related to a chrome extension called "close duplicated tabs" Not true, it happens with the extension removed.]

The result of this error in my case is that all open tabs are lost and history cannot be recovered.

[btlechowski]

Verification passed on

Brave	0.68.109 Chromium: 76.0.3809.62 (Official Build) dev (64-bit)
Revision	7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS	Ubuntu 18.04 LTS

Used test plan from the description and brave/brave-core#2831

Verification passed on

Brave	0.68.106 Chromium: 76.0.3809.62 (Official Build) dev (64-bit)
Revision	7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS	Windows 10 OS Version 1803 (Build 17134.523)

• The issue Uncaught ReferenceError: brave_new_tab is not defined is Reproducible in 0.66.101 in Normal windows/Private Window/Tor window
• Verified the test plan from New Tab Page WebUI: Use Profile Preferences to store page options instead of localStorage brave-core#2831

• Verified Normal/Private/Tor windows

Verified passed with

Brave	0.68.116 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision	111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS	Mac OS X

• Verified the test plan from New Tab Page WebUI: Use Profile Preferences to store page options instead of localStorage brave-core#2831