Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in WelcomeOnboardingActivity #28598

Closed
SergeyZhukovsky opened this issue Feb 18, 2023 · 2 comments · Fixed by brave/brave-core#17298
Closed

Crash in WelcomeOnboardingActivity #28598

SergeyZhukovsky opened this issue Feb 18, 2023 · 2 comments · Fixed by brave/brave-core#17298
Assignees
Labels
crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include

Comments

@SergeyZhukovsky
Copy link
Member

I found that crash in GPS in 1.50.41. I think we have it in stable channel as well, it needs to be fixed and uplifted.

Exception java.lang.NullPointerException: Attempt to invoke virtual method 'void android.view.View.setVisibility(int)' on a null object reference
  at org.chromium.chrome.browser.firstrun.WelcomeOnboardingActivity.nextOnboardingStep (WelcomeOnboardingActivity.java:203)
  at org.chromium.chrome.browser.firstrun.WelcomeOnboardingActivity$$InternalSyntheticLambda$1$3530b3dfe527f64af965f5c728a13398573c192603610d0e99dfaf1d4161d500$0.run$bridge (WelcomeOnboardingActivity.java:18)
  at android.os.Handler.handleCallback (Handler.java:938)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loop (Looper.java:245)
  at android.app.ActivityThread.main (ActivityThread.java:7945)
  at java.lang.reflect.Method.invoke (Method.java)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:631)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:971)
@kjozwiak
Copy link
Member

Going to label this as QA/No as we'll basically verify this by default while running through verifications and reduced manual passes via the next 1.48x RC as the onboarding is always displayed on first launch and QA installs/launches Brave several times while running the builds.

@kjozwiak
Copy link
Member

The above requires 1.48.169 or higher for 1.48.x verification 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants