Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync chain cancellation in Start a new sync chain may confuse users #2863

Closed
btlechowski opened this issue Jan 9, 2019 · 4 comments
Closed

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. Clean profile
  2. Open brave://sync/
  3. Click Start a new sync chain
  4. Click Phone/Tablet
  5. Click Cancel

Actual result:

1 . User clicks Cancel and gets Are you sure? dialog.
image
2. User thinks Yes, Cancel. User clicks Cancel as confirmation of the intent of cancelling the sync.
Alternative choice isn't helpful as it says Exit modal. User wonders what a modal is and if Are you sure? dialog is a modal.

cancel sync

Expected result:

The dialog should not confuse the user

Brave version (brave://version info)

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows

cc @bradleyrichter @rossmoody @brave/legacy_qa

@btlechowski btlechowski added design A design change, especially one which needs input from the design team feature/sync about-pages/sync labels Jan 9, 2019
@btlechowski btlechowski added this to the 1.x Backlog milestone Jan 9, 2019
@rebron
Copy link
Collaborator

rebron commented Jan 10, 2019

Addressing the changes to dialog here to remove references to "modal". #2884

I think we still might need to be clearer with 'Cancel' and 'Exit' on that dialog though.

@srirambv
Copy link
Contributor

@rebron we could just add Cancel Sync Setup on the QR/Code word modal instead of just Cancel. That makes it clear that you want to cancel creating a sync chain. The pop up modal cancel button is self explanatory that you want to cancel the modal and go back

@rebron
Copy link
Collaborator

rebron commented Jan 10, 2019

@srirambv take a look at what @bradleyrichter proposed for #2884. We needed better wording for that dialog anyway. Should be clearer now.

@btlechowski
Copy link
Author

btlechowski commented Jan 18, 2019

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows 7

image

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Linux

image

Verified passed with

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta(64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Mac OS X

screen shot 2019-01-18 at 11 36 35 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants