Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Speedreader message UI #28769

Closed
wchen342 opened this issue Feb 27, 2023 · 1 comment · Fixed by brave/brave-core#17383
Closed

[Android] Speedreader message UI #28769

wchen342 opened this issue Feb 27, 2023 · 1 comment · Fixed by brave/brave-core#17383
Assignees
@wchen342
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/speedreader OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.51.x - Release

Comments

@wchen342
Copy link

Description

Initial simple message UI for toggling speedreader mode on Android.
@wchen342 wchen342 added the OS/Android Fixes related to Android browser functionality label Feb 27, 2023
@wchen342 wchen342 added this to the 1.50.x - Nightly milestone Feb 27, 2023
@wchen342 wchen342 self-assigned this Feb 27, 2023
@wchen342 wchen342 mentioned this issue Feb 27, 2023
Merged
25 tasks
@SergeyZhukovsky SergeyZhukovsky added release-notes/include priority/P3 The next thing for us to work on. It'll ride the trains. feature/speedreader and removed release-notes/exclude labels Feb 27, 2023
@SergeyZhukovsky SergeyZhukovsky removed this from the 1.50.x - Nightly milestone Feb 27, 2023
@wchen342 wchen342 added this to the 1.51.x - Nightly milestone Mar 7, 2023
@kjozwiak kjozwiak added QA/Test-All-Platforms Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected labels Apr 6, 2023
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 27, 2023
@hffvld
Copy link
Contributor

hffvld commented Apr 27, 2023 •
edited
Loading

Verified on Google Pixel 6 and Galaxy Tab S8 and opened follow-up issues #30033 and #30036

Device/OS: 
- Google Pixel 6 [oriole-user 13 TQ2A.230405.003.E1 release-keys]
- SM-X700 Galaxy Tab S8 [gts8wifixx-user 13 TP1A.220624.014 release-keys]
Brave build: 1.51.109 Chromium: 113.0.5672.63 (Official Build) (64-bit)

STEPS:

  1. Go to brave://flags and enable speedreader
  2. Open a new tab and go to a supported URL, for example, https://www.theguardian.com/technology/2023/feb/25/nokia-launches-diy-repairable-budget-android-phone
  3. Now tap on "View original", the original web page shall be displayed instead
  4. Go to another tab, and then switch back. A pop-up shall be displayed under the
    URL bar asking to enable speedreader
  5. Tap "Enable" shall put the page into speedreader mode again

ACTUAL RESULTS:

  • Verified that the supported page is shown in Speedreader Mode
  • Verified that pop-up notification is shown when switching to the supported page
1 2
1 2

This was referenced Apr 27, 2023
Closed
Closed
@hffvld hffvld added QA Pass - Android ARM QA Pass - Android Tab and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 27, 2023
@hffvld hffvld mentioned this issue May 2, 2023
Closed
@kjozwiak kjozwiak mentioned this issue May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wchen342 wchen342

Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/speedreader OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.51.x - Release
Development

Successfully merging a pull request may close this issue.

[Android] Add message UI for speedreader brave/brave-core
4 participants
@kjozwiak @wchen342 @SergeyZhukovsky @hffvld