Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Sync Chain Code dialog text #2885

Closed
rebron opened this issue Jan 9, 2019 · 4 comments
Closed

update Sync Chain Code dialog text #2885

rebron opened this issue Jan 9, 2019 · 4 comments
Assignees
@rossmoody
Labels
feature/sync priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@rebron
Copy link
Collaborator

rebron commented Jan 9, 2019 •
edited
Loading

Description

screen shot 2019-01-09 at 2 53 57 pm

  1. Replace: "I Have a Sync Code."
    with: "I have a Sync Code."

  2. Replace:
    "Type in the below sync chain code words."
    with: "Enter the sync chain code words shown below."
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 9, 2019
@rebron
Copy link
Collaborator Author

rebron commented Jan 9, 2019

cc: @srirambv and @bradleyrichter per Slack conversation on text edits.

@rossmoody rossmoody mentioned this issue Jan 10, 2019
Closed
@rebron rebron mentioned this issue Jan 10, 2019
Closed
@rossmoody rossmoody mentioned this issue Jan 11, 2019
Merged
@cezaraugusto cezaraugusto added this to the 0.59.x - Beta milestone Jan 11, 2019
@btlechowski
Copy link

btlechowski commented Jan 18, 2019 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows 7

Verified the dialog in Start a New Sync Chain, View Sync Code, and Add New Device

image

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Linux

image

Verified passed with

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta(64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Mac OS X

screen shot 2019-01-18 at 11 28 33 am

@srirambv
Copy link
Contributor

Really nice choice of code words "dentist spread asthma", "obvious exclude evil" 😂

@rebron
Copy link
Collaborator Author

rebron commented Jan 23, 2019

@srirambv at @btlechowski there's also "regret affair hotel" in there, LOL. That is one subliminal sync code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rossmoody rossmoody

Labels
feature/sync priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

No branches or pull requests
6 participants
@cezaraugusto @rebron @srirambv @LaurenWags @rossmoody @btlechowski