Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balance or asset are not being updated correctly #28879

Closed
Pavneet-Sing opened this issue Mar 3, 2023 · 2 comments · Fixed by brave/brave-core#17540
Closed

Balance or asset are not being updated correctly #28879

Pavneet-Sing opened this issue Mar 3, 2023 · 2 comments · Fixed by brave/brave-core#17540
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.49.x - Release #3

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Mar 3, 2023 •
edited
Loading

Description

  • Balance or asset are not being updated correctly due to getting old responses after the newer ones and updated state being overridden by the old responses.
  • Assets are not updated correctly after network switching

Actual result

balance-asset-issues.webm

Expected result

Balance and asset should update correctly

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Y
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version? Y
@Pavneet-Sing Pavneet-Sing added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Mar 3, 2023
@Pavneet-Sing Pavneet-Sing self-assigned this Mar 3, 2023
@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 3, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Mar 9, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 10, 2023
This was referenced Mar 10, 2023
Merged
Merged
@kjozwiak
Copy link
Member

The above requires 1.49.124 or higher for 1.49.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.49.126 x64 build

  • Verified steps from brave/brave-core#17540
  • Verified correct token balance is shown when changing network/account
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
28879-ARM.mp4
28879-Tab.mp4

This was referenced Mar 23, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.49.x - Release #3
Development

Successfully merging a pull request may close this issue.

fix(wallet): Show correct balance and asset brave/brave-core
5 participants
@jamesmudgett @kjozwiak @Pavneet-Sing @srirambv @brave-builds