Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Google Sign-In permission #28927

Closed
ShivanKaul opened this issue Mar 6, 2023 · 1 comment · Fixed by brave/brave-core#17428
Closed

[Android] Google Sign-In permission #28927

ShivanKaul opened this issue Mar 6, 2023 · 1 comment · Fixed by brave/brave-core#17428
Assignees
Labels
OS/Android Fixes related to Android browser functionality privacy/permissions privacy features related to limiting, lifetime or other permissions QA Pass - Android Tab QA/Yes release-notes/include

Comments

@ShivanKaul
Copy link
Collaborator

ShivanKaul commented Mar 6, 2023

Android port of brave/brave-core#16595

When feature is on:

  1. Prompt users for Google Sign In permission when visiting websites that use legacy Google Sign In
  2. Have an entry for Google Sign In in Site Settings in Settings. Adding/subtracting exceptions should work.
  3. There shouldn't be any global Allow Google Login toggle under Social Media Blocking in Settings under Privacy & shields
@ShivanKaul ShivanKaul added the OS/Android Fixes related to Android browser functionality label Mar 6, 2023
@ShivanKaul ShivanKaul self-assigned this Mar 6, 2023
@ShivanKaul ShivanKaul added the privacy/permissions privacy features related to limiting, lifetime or other permissions label Mar 10, 2023
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 10, 2023
@Uni-verse
Copy link
Contributor

Uni-verse commented May 2, 2023

Verified on Samsung Galaxy Tab S7 using version:

Brave	1.51.109 Chromium: 113.0.5672.63 (Official Build) (64-bit) 
Revision	0e1a4471d5ae5bf128b1bd8f4d627c8cbd55f70c-refs/branch-heads/5672@{#912}
OS	Android 13; Build/TP1A.220624.014; 33; REL

Test Plan: brave/brave-core#16595 (comment)

Feature Flag_PASSED
  • Verified Google Sign-in permission is disabled when set to default.
  • Verified pop-up is shown when signing in to www.fandango.com if feature flag #brave-google-sign-in-permission is enabled.
  • Verified sign-in permission pop-up not shown when logging into www.fandango.com if feature flag is disabled or set to default.
Example Example Example
screenshot-1682975856172 screenshot-1682972758246 screenshot-1683037732231
Functionality_PASSED

New Profile

Upgraded Profile

  • Verified that installing 1.50.x and then upgrading to 1.51.x and then enabling #google-sign-in-permission feature flag will display the sign in permission when signing in. User is able to sign in successfully.
  • Verified that the Allow Google logins on 3rd party sites is removed on upgraded profile
Example Example Example
screenshot-1683039168486 screenshot-1682974824339 screenshot-1682977482072
Brave Settings_PASSED
  • Verified Allow Google login buttons on third party sites Social Media Blocking switch is removed when feature is enabled and is shown if disabled.
  • Verified that Google Sign-in permission is blocked when signing in on website using 3rd party cookies after manual adding the site exception (block) under site settings.
  • Verified that Google Sign-in permission is allowed when manually adding site exception under site settings
Example Example Example Example
screenshot-1682976295414 screenshot-1682977214660 screenshot-1683041332619 screenshot-1683042122153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality privacy/permissions privacy features related to limiting, lifetime or other permissions QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants