Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scriptlet arguments with quotes or backslashes #29099

Closed
antonok-edm opened this issue Mar 15, 2023 · 3 comments · Fixed by brave/brave-core#17629
Closed

Support scriptlet arguments with quotes or backslashes #29099

antonok-edm opened this issue Mar 15, 2023 · 3 comments · Fixed by brave/brave-core#17629
Assignees
Labels

Comments

@antonok-edm
Copy link
Collaborator

See brave/adblock-rust#237 for details. This is now starting to cause problems on some sites which rely on scriptlets with quoted arguments in upstream uBO lists. For example, the following rule:

lightnovelpub.*,[lightnovelworld.com](http://lightnovelworld.com/),[novelpub.com](http://novelpub.com/),[webnovelpub.com##+js(nostif](http://webnovelpub.com/##+js(nostif), (""))

Without that rule working properly, https://lightnovelpub.com appears with gray placeholders where the images should be.

@antonok-edm antonok-edm added feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop labels Mar 15, 2023
@antonok-edm antonok-edm self-assigned this Mar 15, 2023
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 16, 2023
@mkarolin
Copy link
Contributor

@antonok-edm could you, please, set the appropriate QA and release-notes labels, if needed.

@antonok-edm antonok-edm changed the title Support scriptlet arguments with quotes Support scriptlet arguments with quotes or backslashes Mar 17, 2023
@stephendonner
Copy link

Verified PASSED using

Brave 1.51.77 Chromium: 112.0.5615.49 (Official Build) beta (64-bit)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS Windows 10 Version 22H2 (Build 19045.2788)

Steps:

  1. installed 1.51.77
  2. launched Brave
  3. loaded https://lightnovelpub.com/
  4. looked for the light-novel images
  5. compared to 1.49.130 and 1.50.113

Confirmed I could again see images on https://lightnovelpub.com/, below a gray (also blank, but not part of this issue) advertisement placeholder

1.51.77 1.50.113
image (9) image (8)

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 26, 2023
@hffvld
Copy link
Contributor

hffvld commented Apr 26, 2023

Verified, the issue is not reproducible in build 1.51.x. Gray placeholders instead of images are not show anymore.


Device/OS: Pixel 6 [oriole-user 13 TQ2A.230405.003.E1 release-keys]
Brave build: 1.51.105 [Beta]

Screenshot/Screencast:

1 2
1 2

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants