Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show overlapping network icon and network name on assets list item #29165

Closed
Pavneet-Sing opened this issue Mar 20, 2023 · 1 comment · Fixed by brave/brave-core#17692
Closed

Show overlapping network icon and network name on assets list item #29165

Pavneet-Sing opened this issue Mar 20, 2023 · 1 comment · Fixed by brave/brave-core#17692
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.51.x - Release

Comments

@Pavneet-Sing
Copy link

Description

Show overlapping network icon and network name on assets list item on Portfolio

Image:

Screenshot from 2023-03-20 13-56-23
@Pavneet-Sing Pavneet-Sing added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Mar 20, 2023
@Pavneet-Sing Pavneet-Sing self-assigned this Mar 20, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Mar 21, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 22, 2023
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.51.87 x64 Beta build

  • Verified steps from issue description and brave/brave-core#17692
  • Verified network icon is added to all assets to differentiate visually
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
17692-ARM.mp4
17692-Tab.mp4

@kjozwiak kjozwiak mentioned this issue May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.51.x - Release
Development

Successfully merging a pull request may close this issue.

Feat show network name and icon brave/brave-core
3 participants
@Pavneet-Sing @srirambv @brave-builds