Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing network icons to show Android #29166

Closed
Pavneet-Sing opened this issue Mar 20, 2023 · 1 comment · Fixed by brave/brave-core#17692
Closed

Add missing network icons to show Android #29166

Pavneet-Sing opened this issue Mar 20, 2023 · 1 comment · Fixed by brave/brave-core#17692
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.51.x - Release

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Mar 20, 2023 •
edited
Loading

Description

Add missing network icons (Aurora, Arbitrum etc.) to show actual icon instead of ETH icon on Asset list (Portfolio etc).

Expected

Should show the correct network icon in asset list (e.g. Portfolio, add assets, buy, send, swap etc.)

Related: Update ETH icon to use Aurora ETH icon
@Pavneet-Sing Pavneet-Sing added the OS/Android Fixes related to Android browser functionality label Mar 20, 2023
@Pavneet-Sing Pavneet-Sing self-assigned this Mar 20, 2023
@Pavneet-Sing Pavneet-Sing added QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support release-notes/include priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 20, 2023
@Pavneet-Sing Pavneet-Sing changed the title Add missing asset icons in browser registry to be reused cross platform (Android) Add missing network icons to show Android Mar 20, 2023
This was referenced Mar 20, 2023
Closed
Merged
@StephenHeaps StephenHeaps mentioned this issue Mar 21, 2023
Closed
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 22, 2023
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.51.87 x64 Beta build

  • Verified steps from issue description and brave/brave-core#17692
  • Verified Network icon is shown for native assets as expected
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
17692-ARM.mp4
17692-Tab.mp4

@kjozwiak kjozwiak mentioned this issue May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.51.x - Release
Development

Successfully merging a pull request may close this issue.

Feat show network name and icon brave/brave-core
3 participants
@Pavneet-Sing @srirambv @brave-builds