Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Wallet) Remove NFTs from Portfolio #29330

Closed
simoarpe opened this issue Mar 27, 2023 · 1 comment · Fixed by brave/brave-core#17797
Closed

(Wallet) Remove NFTs from Portfolio #29330

simoarpe opened this issue Mar 27, 2023 · 1 comment · Fixed by brave/brave-core#17797
Assignees
@simoarpe
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.51.x - Release

Comments

@simoarpe
Copy link

Description

Removes NFTs from Portfolio section in Brave Wallet.

Screenshot_1679909671
@simoarpe simoarpe added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Mar 27, 2023
@simoarpe simoarpe self-assigned this Mar 27, 2023
This was referenced Mar 27, 2023
Closed
Merged
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 28, 2023
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.51.79 x64 build

  • Verified steps from brave/brave-core#17797
  • Verified on upgrade from previous version, added NFT's are automatically removed from portfolio and added under the NFT tab
  • Verified on clean install a NFT tab is shown by default
  • Verified adding an custom token which is NFT is automatically listed under the NFT tab
  • Encountered #29615 & #29616
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
29330-ARM.mp4
29330-Tab.mp4

@kjozwiak kjozwiak mentioned this issue May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoarpe simoarpe

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.51.x - Release
Development

Successfully merging a pull request may close this issue.

Remove NFT list from Portfolio section brave/brave-core
3 participants
@simoarpe @srirambv @brave-builds