Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not change adsPerDay through UI #2977

Closed
btlechowski opened this issue Jan 16, 2019 · 1 comment
Closed

Can not change adsPerDay through UI #2977

btlechowski opened this issue Jan 16, 2019 · 1 comment

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. Go to brave://rewards
  2. Enable rewards
  3. Enable ads
  4. Click on Ads Settings

Actual result:

Not possible to change adsPerDay through UI
Only possible to set adds per hour
image

Expected result:

Possible to change adsPerDay through UI
Which is required by the Brave Ads Client V1.0 Client spec:
Follow max ads per day and max ads per hour user settings for capping ads

Brave version (brave://version info)

Brave 0.60.13 Chromium: 72.0.3626.53 (Official Build) dev (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows

cc @mrose17 @brave/legacy_qa

@mrose17
Copy link
Member

mrose17 commented Jan 16, 2019

I am reliably informed that this is no longer a requirement. Perhaps in the future, we may bring it back!

@mrose17 mrose17 closed this as completed Jan 16, 2019
@kjozwiak kjozwiak modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Jan 17, 2019
@rebron rebron removed this from the Dupe / Invalid / Not actionable milestone May 8, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants