Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement conversion logic for search result ads #29889

Closed
tmancey opened this issue Apr 20, 2023 · 1 comment · Fixed by brave/brave-core#18277
Closed

Implement conversion logic for search result ads #29889

tmancey opened this issue Apr 20, 2023 · 1 comment · Fixed by brave/brave-core#18277
Assignees
@tmancey
Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.56.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Apr 20, 2023

No description provided.

@tmancey tmancey added enhancement priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude feature/ads OS/Desktop labels Apr 20, 2023
@tmancey tmancey self-assigned this Apr 20, 2023
@tmancey tmancey added QA/Yes and removed QA/No labels Apr 27, 2023
@tmancey tmancey mentioned this issue Apr 27, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone May 3, 2023
@btlechowski
Copy link

Verification passed on

Brave 1.53.99 Chromium: 114.0.5735.133 (Official Build) beta (64-bit)
Revision fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#18277

Verified ads are converted when ads disabled

Verified ads are converted when ads enabled

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.56.x - Release
Development

Successfully merging a pull request may close this issue.

Implement conversion logic for search result ads brave/brave-core
3 participants
@tmancey @btlechowski @brave-builds