Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to close grant notification by clicking ok button #2998

Closed
srirambv opened this issue Jan 17, 2019 · 3 comments
Closed

Unable to close grant notification by clicking ok button #2998

srirambv opened this issue Jan 17, 2019 · 3 comments

Comments

@srirambv
Copy link
Contributor

Description

Unable to close grant notification by clicking ok button

Steps to Reproduce

  1. Clean profile on 0.59.24
  2. Click on BR panel button, shows Token grant notification
  3. Click the OK button, notification doesn't dismiss, have to click the notification close button to dismiss it

Actual result:

rewards

Expected result:

Should be able to clear the notification by clicking the ok button

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta(64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes only on Beta

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

#2833

@srirambv srirambv added this to the 1.x Backlog milestone Jan 17, 2019
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.59.x - Beta Jan 17, 2019
@btlechowski
Copy link

Unable to reproduce on Windows 7 x64

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows 7

2998

@ryanml
Copy link
Contributor

ryanml commented Jan 21, 2019

See this fix which was uplifted in to 0.59.x here: brave/brave-core#1388

This addresses the issue where the panel was showing when rewards disabled, and in turn will solve this issue. @srirambv please let me know there was something else with this one, thanks!

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants