Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist NTP-SI index and for both Rewards and non-Rewards users #30010

Closed
tmancey opened this issue Apr 26, 2023 · 1 comment · Fixed by brave/brave-core#18433
Closed

Persist NTP-SI index and for both Rewards and non-Rewards users #30010

tmancey opened this issue Apr 26, 2023 · 1 comment · Fixed by brave/brave-core#18433

Comments

@tmancey
Copy link
Contributor

tmancey commented Apr 26, 2023

New tab page sponsored image should be shown every 4th new tab (open, refresh, or relaunch of browser) and on the 2nd new tab (open, refresh or relaunch of the browser) for a fresh install. The index for when to show a new tab sponsored image should not change for non visible tabs during restoration of tabs.

@btlechowski
Copy link

Verification passed on

Brave 1.53.99 Chromium: 114.0.5735.133 (Official Build) beta (64-bit)
Revision fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#18433

Confirmed on fresh install the first NTT ad is shown on the 2nd new tab

Confirm subsequent NTT ads are shown every 4th new tab

Confirm browser relaunches persist the the count between new tabs

Confirm restored tabs (non visible) do not increment the count after relaunching the browser

Confirm opening a new tab and relaunching the browser many times shows an NTT ad every nth tab

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants