Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observed multiple calls that are not "*.brave.com" when first time launching the app #30114

Open
hffvld opened this issue May 3, 2023 · 2 comments
Assignees
Labels
bug OS/Android Fixes related to Android browser functionality QA/Yes

Comments

@hffvld
Copy link
Contributor

hffvld commented May 3, 2023

Description

Observed multiple calls that are not *.brave.com when first time launching the app

Steps to reproduce

  1. Uninstall and fresh install Brave
  2. Launch the app
  3. Check calls in Charles Proxy

Actual result

I see google calls when first time launching the app

1.51.x #1 1.51.x #2 1.50.x
1 2 3
1 2 3
1 2 3

Expected result

Brave must only contact *.brave.com endpoints on the first launch

Issue reproduces how often

Easily reproduced

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Galaxy Tab S8 [Tablet]
  • Android version: Android 13 [gts8wifixx-user 13 TP1A.220624.014 release-keys]

Brave version

1.51.110 Chromium: 113.0.5672.77 (Official Build) (32-bit)
1.50.121 Chromium: 112.0.5615.138 (Official Build) (32-bit)

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@hffvld hffvld added OS/Android Fixes related to Android browser functionality bug QA/Yes labels May 3, 2023
@SergeyZhukovsky
Copy link
Member

Some of them are mentioned in that issue #15167 as well.

@SergeyZhukovsky
Copy link
Member

SergeyZhukovsky commented May 24, 2023

@vlad-hoff are you sure all the requests come from Brave? It's easy to say if you take a look on a UA string. It should look like
Mozilla/5.0 (Linux; Android 12) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.0.0 Mobile Safari/537.36 or similar. From what I see on my tests calls to play.googleapis.com for example come from something Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.32 Safari/537.36 with an ancient Chrome 60. Calls to connectivitycheck.gstatic.com are also from the same cr60 UA.
config.edge.skype.com from Dalvik/2.1.0 (Linux; U; Android 12; SM-G973F Build/SP1A.210812.016)
in.appcenter.ms from Dalvik/2.1.0 (Linux; U; Android 12; SM-G973F Build/SP1A.210812.016)
self.events.data.microsoft.com from Dalvik/2.1.0 (Linux; U; Android 12; SM-G973F Build/SP1A.210812.016)
play-fe.googleapis.com from com.android.vending/83571920 (Linux; U; Android 12; en_CA; SM-G973F; Build/SP1A.210812.016; Cronet/113.0.5672.24)
I'm not sure what is googlevideo.com in your tests as I never had that unless I go directly to that website.
There is a list of other calls that we do and explanation to them:

www.gstatic.com                                - a json list of suggested sites for NTP
static.xx.fbcdn.net                              - facebook icon on NTP
images-na.ssl-images-amazon.com  - amazon icon on NTP
a.espncdn.com                                   - espn icon on NTP
en.m.wikipedia.org                             - wikipedia icon on NTP
s.yimg.com                                         - yahoo icon on NTP
ir.ebaystatic.com                                - ebay icon on NTP
www.instagram.com                           - instagram icon on NTP

So far I don't see any unexpected calls. Let me know if you have some concerns or questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug OS/Android Fixes related to Android browser functionality QA/Yes
Projects
None yet
Development

No branches or pull requests

2 participants