Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve text on aggressive mode interstitial to explain link to aggressive mode #30142

Closed
pes10k opened this issue May 4, 2023 · 6 comments · Fixed by brave/brave-core#18745
Assignees
Labels
needs-text-change This change requires some careful wording. OS/Android Fixes related to Android browser functionality OS/Desktop privacy/feature User-facing privacy- & security-focused feature work. privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass - Android ARM QA Pass-macOS QA/Yes release-notes/include

Comments

@pes10k
Copy link
Contributor

pes10k commented May 4, 2023

Some users are surprised when they see the interstitial appear in aggressive mode.

https://bravesoftware.slack.com/archives/C6YNM6Y5S/p1683211033792949

It would be good to add additional text stating (straw text)

  • this is because of aggressive mode
  • brave by default protects your privacy on every site you visit
  • this dialog is an extra aggressive warning that you're visiting a site that may be privacy-hostile
@pes10k pes10k added OS/Android Fixes related to Android browser functionality OS/Desktop needs-text-change This change requires some careful wording. privacy/feature User-facing privacy- & security-focused feature work. privacy-pod Feature work for the Privacy & Web Compatibility pod labels May 4, 2023
@pilgrim-brave
Copy link

Proposed text: "Because you requested to aggressively block trackers and ads, Brave is blocking this site before the first network connection."

Screenshot 2023-06-02 at 11 26 51 AM

@LaurenWags
Copy link
Member

@pilgrim-brave @pes10k could one of you please provide a test plan for this one as it's labeled QA/Yes. Thanks!

@pes10k
Copy link
Contributor Author

pes10k commented Jun 30, 2023

@LaurenWags this should work:

  1. visit https://antitracking.owncast.online/ with aggressive blocking
  2. verify that the text has been changed and matches @pilgrim-brave 's screenshot above

@LaurenWags
Copy link
Member

Thanks @pes10k!

@stephendonner
Copy link

Verified PASSED using

Brave 1.57.2 Chromium: 115.0.5790.56 (Official Build) beta (x86_64)
Revision ebcfb87c1393f36955cfa2f6451a1767e3dc3ee5-refs/branch-heads/5790@{#1193}
OS macOS Version 11.7.8 (Build 20G1351)

Steps:

  1. installed 1.57.2
  2. launched Brave
  3. loaded https://antitracking.owncast.online/
  4. confirmed no interstitial-blocking message
  5. switched to Aggressively block trackers & ads in the Shields dropdown
  6. confirmed page reloaded, now with intersitial-blocking message
  7. clicked on Proceed
  8. confirmed I was shown https://antitracking.owncast.online/ without the interstitial
example example example example example
Screen Shot 2023-07-07 at 11 47 31 PM Screen Shot 2023-07-07 at 11 48 00 PM Screen Shot 2023-07-07 at 11 48 18 PM Screen Shot 2023-07-07 at 11 48 21 PM Screen Shot 2023-07-07 at 11 48 49 PM

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 3, 2023
@hffvld
Copy link
Contributor

hffvld commented Aug 3, 2023

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 UPB4.230623.007 release-keys]
Brave build: 1.57.33
Chromium: 115.0.5790.114 (Official Build) beta (64-bit) 
Revision: 86b4ea1d70ce73c4468d84cc8277f1f9de14b8bc

STEPS:

  1. Launch Brave
  2. Three-dot menu > Settings > Brave Shields & privacy
  3. Block trackers & ads > Allow all trackers & ads > Done
  4. Close settings and open https://antitracking.owncast.online/ > Verify
  5. Now change Block trackers & ads to Block trackers & ads (Standard) > Done
  6. Close settings and open https://antitracking.owncast.online/ > Verify
  7. Now change Block trackers & ads to Block trackers & ads (Aggressive) > Done
  8. Close settings and open https://antitracking.owncast.online/ > Verify

ACTUAL RESULTS:

  • Verified that no interstitial-blocking message is shown when Block trackers & ads is set to Allow all trackers & ads or Block trackers & ads (Standard)
  • Verified that page reloaded when Block trackers & ads updated to Block trackers & ads (Aggressive) and now shows intersitial-blocking message
  • Verified when Block trackers & ads is set to Block trackers & ads (Aggressive) and intersitial-blocking message is shown, tapping Proceed is loading proper page

Allow all trackers & ads Block trackers & ads (Standard) Block trackers & ads (Aggressive)
1 2 3
1 2 3
1 2 3
1 2 3
1 2 3
1 2 3
1 2 3

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-text-change This change requires some careful wording. OS/Android Fixes related to Android browser functionality OS/Desktop privacy/feature User-facing privacy- & security-focused feature work. privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass - Android ARM QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants