Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer fails to connect to laptop-updates.brave.com when sending pings on Windows 7 #3030

Open
btlechowski opened this issue Jan 21, 2019 · 2 comments
Labels
installer/omaha Issues for windows omaha installer OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes

Comments

@btlechowski
Copy link

Follow up from #2917

Steps to Reproduce

  1. Uninstall Brave though Control Panel
  2. Enable Omaha logging Regular stub installer does not send download-complete and installer-run pings #2917 (comment)
  3. Run Brave stub installer
  4. After installation check installer log in c:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log

Actual result:

All pings fail with error 0x80072efe when connecting to laptop-updates.brave.com

[01/21/19 03:16:29.136][BraveBrowserSilentBetaSetup-ZTT758][3792:6060][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.0.0&channel=beta&ref=ZTT758&event=startup][request=][filename=]
[01/21/19 03:16:29.854][BraveBrowserSilentBetaSetup-ZTT758][3792:6060][Send response received][result 0x80072efe][status code 0][]
[01/21/19 03:17:53.427][BraveUpdate:goopdate][1128:8688][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=ZTT758&event=download-complete][request=][filename=]
[01/21/19 03:17:53.910][BraveUpdate:goopdate][1128:8688][Send response received][result 0x80072efe][status code 0][]
[01/21/19 03:18:03.115][BraveUpdate:goopdate][1128:8688][Send][url=https://laptop-updates.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=ZTT758&event=installer-run][request=][filename=]
[01/21/19 03:18:03.599][BraveUpdate:goopdate][1128:8688][Send response received][result 0x80072efe][status code 0][]

Full log:
BraveUpdateSilentFail.log

Important: does not reproduce on laptop-updates-pre.brave.com server

[01/21/19 05:25:48.529][BraveBrowserSilentBetaSetup-PSN487][10732:8964][Send][url=https://laptop-updates-pre.brave.com/1/installerEvent?platform=winx64-bc&version=0.0.0&channel=beta&ref=PSN487&event=startup][request=][filename=]
[01/21/19 05:25:49.379][BraveBrowserSilentBetaSetup-PSN487][10732:8964][Send response received][result 0x0][status code 200][{"ts":1548044750649,"status":"ok"}]
[01/21/19 05:26:44.484][BraveUpdate:goopdate][3412:4232][Send][url=https://laptop-updates-pre.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=PSN487&event=download-complete][request=][filename=]
[01/21/19 05:26:45.087][BraveUpdate:goopdate][3412:4232][Send response received][result 0x0][status code 200][{"ts":1548044806354,"status":"ok"}]
[01/21/19 05:26:46.087][BraveUpdate:goopdate][3412:4232][Send][url=https://laptop-updates-pre.brave.com/1/installerEvent?platform=winx64-bc&version=0.59.26&channel=beta&ref=PSN487&event=installer-run][request=][filename=]
[01/21/19 05:26:46.564][BraveUpdate:goopdate][3412:4232][Send response received][result 0x0][status code 200][{"ts":1548044807831,"status":"ok"}]

Full log:
BraveUpdateSilentPass.log

Expected result:

pings are sent successfully

Reproduces how often:

always

Brave version (brave://version info)

Brave 0.59.26 Chromium: 72.0.3626.64 (Official Build) beta (64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Windows 7 x64

Does not reproduce on Windows 10 x64

cc @brave/legacy_qa @aekeus @emerick

@btlechowski btlechowski added this to the 1.x Backlog milestone Jan 21, 2019
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. installer/omaha Issues for windows omaha installer labels Jan 22, 2019
@btlechowski btlechowski changed the title Failed to connect to laptop-updates.brave.com when sending pings on Windows 7 Installer fails to connect to laptop-updates.brave.com when sending pings on Windows 7 Jan 22, 2019
@btlechowski
Copy link
Author

During triage meeting @mkarolin suggested that TLS version could be the problem. This is likely, because the installer uses WinHttp also.
More info:
#1188 (comment)

@emerick This could be an easy fix if all we need to do is change some flags.

@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@bsclifton
Copy link
Member

@btlechowski have you experienced any issues with this recently?

Would be great to see what options are available for the stub installer. It doesn't seem like TLS 1.2 is available on Windows 7/8/8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installer/omaha Issues for windows omaha installer OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes
Projects
Status: P3 Backlog
Development

No branches or pull requests

3 participants