Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove widget promo #30618

Closed
deeppandya opened this issue May 26, 2023 · 5 comments · Fixed by brave/brave-core#18638
Closed

Remove widget promo #30618

deeppandya opened this issue May 26, 2023 · 5 comments · Fixed by brave/brave-core#18638
Assignees
@deeppandya
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/widgets OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Test-All-Platforms QA/Yes release/blocking release-notes/include
Milestone
1.52.x - Release

Comments

@deeppandya
Copy link

This issue is to remove widget promo to improve UX.
For more context : https://bravesoftware.slack.com/archives/C0816QH3R/p1684715131423109
@deeppandya deeppandya added the OS/Android Fixes related to Android browser functionality label May 26, 2023
@deeppandya deeppandya self-assigned this May 26, 2023
@deeppandya deeppandya mentioned this issue May 26, 2023
Merged
25 tasks
@kjozwiak
Copy link
Member

We'll want this into 1.52.x which will fix the issue that @bbondy mentioned via the thread @deeppandya referenced. UX/UI will be improved 1.53.x re: the widget promo.

@kjozwiak kjozwiak added this to the 1.52.x - Release milestone May 26, 2023
@kjozwiak kjozwiak added feature/widgets QA/Test-All-Platforms Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected labels May 26, 2023
This was referenced May 26, 2023
Merged
Merged
@kjozwiak
Copy link
Member

The above requires 1.52.115 or higher for 1.52.x verification 👍

@kjozwiak kjozwiak mentioned this issue May 30, 2023
Closed
@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 using the following build(s):

Brave	1.52.115 Chromium: 114.0.5735.53 (Official Build) (64-bit) 
Revision	c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS	Android 13; Build/TP1A.220624.014; 33; REL

Using Test Plan in brave/brave-core#18638 (comment)

Test Case #1 (opening tabs/restarting browser)

  • opened ~30 tabs and ensured that the OSK is being shown when tapping on the omnibox every single time
    • ensured that the Widget onboarding modal isn't triggered/appearing when tapping on the omnibox
    • after opening ~30 different tabs, restart the browser ~20 times and ensured that the Widget onboarding isn't displayed
    • ensured that you can still add a home widget via Hambruger Menu -> Settings -> Home screen widget
      • ensured that you can add other Brave widgets via Widgets on the Android Home screen
  • ensured that all the widgets are removed when Brave is uninstalled

Test Case #2 (restarting browser/opening tabs)

  • opened Brave ~30 times and ensured that the OSK is being shown when tapping on the omnibox every single time
    • ensured that the Widget onboarding modal isn't triggered/appearing when tapping on the omnibox
    • after opening Brave ~30 different times, opened ~20 tabs and ensured that the Widget onboarding isn't displayed
    • ensured that you can still add a home widget via Hambruger Menu -> Settings -> Home screen widget
      • ensured that you can add other Brave widgets via Widgets on the Android Home screen
  • ensured that all the widgets are removed when Brave is uninstalled

Test Case #3 (Existing Profile)

  • Opened brave ~30 times after upgrading version to 1.52.115 to make sure OSK is shown each time on NTP.
  • Ensured that you can add other Brave widgets via Widgets on the Android Home screen
  • ensured that all the widgets are removed when Brave is uninstalled

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy Tab S7 using the following build(s):

Brave	1.52.115 Chromium: 114.0.5735.53 (Official Build) (64-bit) 
Revision	c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS	Android 13; Build/TP1A.220624.014; 33; REL

Using Test Plan in brave/brave-core#18638 (comment)

Test Case #1 (opening tabs/restarting browser)

  • opened ~30 tabs and ensured that the OSK is being shown when tapping on the omnibox every single time
    • ensured that the Widget onboarding modal isn't triggered/appearing when tapping on the omnibox
    • after opening ~30 different tabs, restart the browser ~20 times and ensured that the Widget onboarding isn't displayed
    • ensured that you can still add a home widget via Hambruger Menu -> Settings -> Home screen widget
      • ensured that you can add other Brave widgets via Widgets on the Android Home screen
  • ensured that all the widgets are removed when Brave is uninstalled

Test Case #2 (restarting browser/opening tabs)

  • opened Brave ~30 times and ensured that the OSK is being shown when tapping on the omnibox every single time
    • ensured that the Widget onboarding modal isn't triggered/appearing when tapping on the omnibox
    • after opening Brave ~30 different times, opened ~20 tabs and ensured that the Widget onboarding isn't displayed
    • ensured that you can still add a home widget via Hambruger Menu -> Settings -> Home screen widget
      • ensured that you can add other Brave widgets via Widgets on the Android Home screen
  • ensured that all the widgets are removed when Brave is uninstalled

@Uni-verse
Copy link
Contributor

Uni-verse commented May 30, 2023 •
edited
Loading

Verified on Pixel 5 using the following version(s):

Brave	1.52.115 Chromium: 114.0.5735.53 (Official Build) (32-bit) 
Revision	c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS	Android 8.0.0; Build/OSR1.180418.026; 26; REL

Using Test Plan in brave/brave-core#18638 (comment)

Test Case #1 (opening tabs/restarting browser)

  • opened ~30 tabs and ensured that the OSK is being shown when tapping on the omnibox every single time
    • ensured that the Widget onboarding modal isn't triggered/appearing when tapping on the omnibox
    • after opening ~30 different tabs, restart the browser ~20 times and ensured that the Widget onboarding isn't displayed
    • ensured that you can still add a home widget via Hambruger Menu -> Settings -> Home screen widget
      • ensured that you can add other Brave widgets via Widgets on the Android Home screen
  • ensured that all the widgets are removed when Brave is uninstalled

Test Case #2 (restarting browser/opening tabs)

  • opened Brave ~30 times and ensured that the OSK is being shown when tapping on the omnibox every single time
    • ensured that the Widget onboarding modal isn't triggered/appearing when tapping on the omnibox
    • after opening Brave ~30 different times, opened ~20 tabs and ensured that the Widget onboarding isn't displayed
    • ensured that you can still add a home widget via Hambruger Menu -> Settings -> Home screen widget
      • ensured that you can add other Brave widgets via Widgets on the Android Home screen
  • ensured that all the widgets are removed when Brave is uninstalled

@kjozwiak kjozwiak mentioned this issue May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/widgets OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Test-All-Platforms QA/Yes release/blocking release-notes/include
Projects
None yet
Milestone
1.52.x - Release
Development

Successfully merging a pull request may close this issue.

Remove widget promo brave/brave-core
3 participants
@kjozwiak @deeppandya @Uni-verse