Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstaller is unsigned #3063

Closed
da2x opened this issue Jan 23, 2019 · 2 comments
Closed

Uninstaller is unsigned #3063

da2x opened this issue Jan 23, 2019 · 2 comments
Assignees
Labels
priority/P3 The next thing for us to work on. It'll ride the trains. sec-low security setup/installer

Comments

@da2x
Copy link

da2x commented Jan 23, 2019

Description

The uninstaller is unsigned.

Steps to Reproduce

  1. Install Brave on Windows
  2. Uninstall Brave again

Actual result:

Triggers uninstaller with an UAC dialog. Dialog warns that the uninstaller is unsigned and from an unknown developer.

Expected result:

A signed uninstaller just like the installer and the main program.

Reproduces how often:

Every time.

Brave version (brave://version info)

Brave | 0.60.16 Chromium: 72.0.3626.64 (Official Build) dev (64-bit)
Revision | eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS | Windows

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Stable and developer.

Additional Information

Clearly an oversight in the signing process on he build-system.

@tildelowengrimm tildelowengrimm added security sec-low priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 24, 2019
@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 28, 2019
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@jumde
Copy link
Contributor

jumde commented Jul 23, 2019

@da2x - I'm not able to repro this on Win 10 with the latest release (0.66.101), could you confirm if this is fixed for you as well? cc: @mbacchi

@bsclifton
Copy link
Member

Closing - let's re-open if the issue still exists

@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/P3 The next thing for us to work on. It'll ride the trains. sec-low security setup/installer
Projects
None yet
Development

No branches or pull requests

8 participants