Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get asset info for EVM assets when contract address is inputted #31062

Closed
HEagle18 opened this issue Jun 14, 2023 · 4 comments · Fixed by brave/brave-core#21191
Closed

get asset info for EVM assets when contract address is inputted #31062

HEagle18 opened this issue Jun 14, 2023 · 4 comments · Fixed by brave/brave-core#21191
Assignees
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include

Comments

@HEagle18
Copy link

HEagle18 commented Jun 14, 2023

Description

at the moment, we only asset info for assets on Ethereum Mainnet. We should enable this for all other preloaded networks and potentially Arbitrum and Zksync networks.

Steps to Reproduce

  1. try adding GMX (contract address -> 0x62edc0692bd897d2295872a9ffcac5425011c661 https://www.coingecko.com/en/coins/gmx) to brave wallet

Actual result:

Screenshot 2023-06-14 at 21 38 23

Expected result:

Reproduces how often:

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@HEagle18 HEagle18 added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop labels Jun 14, 2023
@HEagle18 HEagle18 added this to Web3 Jun 14, 2023
@Douglashdaniel
Copy link

We need some brave-wallet-core support to do this. At the moment our assetRatioService.getTokenInfo(contract_address) method can only query Token Info from the Ethereum Mainnet, EVM chains and Solana networks are not supported.

We should add a chainId argument getTokenInfo(contract_address, chain_id) to allow querying Token Info for other chains.

@jamesmudgett jamesmudgett added the priority/P4 Planned work. We expect to get to it "soon". label Jun 16, 2023
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Jun 16, 2023
@onyb
Copy link
Member

onyb commented Mar 6, 2024

Fixed in brave/brave-core#21191

@srirambv
Copy link
Contributor

srirambv commented Mar 6, 2024

Verification passed on

Brave 1.63.169 Chromium: 122.0.6261.111 (Official Build) (64-bit)
Revision 0e0a975cf46d4d026e184ca61788e1da6f0d76bc
OS Windows 11 Version 23H2 (Build 22631.3155)
  • Verified steps from issue description
  • Verified able to add EVM tokens
  • Verified adding contract address automatically populates the token details
31062.mp4

@srirambv
Copy link
Contributor

srirambv commented Mar 6, 2024

Verification passed on Google Pixel 8 with Android 14 running 1.63.169 x64 build
-Verified steps from issue description
Verified able to add EVM tokens
Verified adding contract address automatically populates the token details

31062.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants