Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the "BETA" tag under brave://sync #3110

Closed
kjozwiak opened this issue Jan 25, 2019 · 1 comment
Closed

improve the "BETA" tag under brave://sync #3110

kjozwiak opened this issue Jan 25, 2019 · 1 comment

Comments

@kjozwiak
Copy link
Member

Description

We decided to add a Beta string into brave://sync but due to time constraints and limited resources as folks were on PTO, we added some text rather than making it look like it did under muon. The current fix looks a bit sloppy and needs to be improved.

Steps to Reproduce

  1. open 0.59.30 Chromium: 72.0.3626.71
  2. visit brave://sync

Actual result:

screen shot 2019-01-25 at 4 03 36 pm

Expected result:

screen shot 2019-01-25 at 4 09 39 pm

The above or something similar that looks better.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave 0.59.30 Chromium: 72.0.3626.71 (Official Build) (64-bit)
Revision f52ccad2a6a3c65fc9e0c591a517ceab1198dac0-refs/branch-heads/3626@{#763}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Reproducible on all channels that have Sync enabled by default

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

CCing @rebron & @bsclifton

@kjozwiak kjozwiak added this to the 1.x Backlog milestone Jan 25, 2019
@rossmoody rossmoody self-assigned this Jan 25, 2019
@rossmoody
Copy link
Contributor

After talking with @rebron yesterday in the office, the consensus is to not add the beta label to this and the change that created the above (beta) string has been reverted. So it will just read Sync Setup.

@rebron rebron added this to the Dupe / Invalid / Not actionable milestone Mar 13, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants