Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] External deep link behaviour #31148

Closed
2 tasks done
deeppandya opened this issue Jun 19, 2023 · 2 comments · Fixed by brave/brave-core#19107
Closed
2 tasks done

[Android] External deep link behaviour #31148

deeppandya opened this issue Jun 19, 2023 · 2 comments · Fixed by brave/brave-core#19107

Comments

@deeppandya
Copy link

deeppandya commented Jun 19, 2023

  • Deep link behaviour for already installed application
    In this scenario, we assume that user has already gone through the onboarding. so we don not need to do anything for existing users.
  • Deep link behaviour for fresh install
    In this scenario, we need to show app onboarding with Help make Brave better and Set as default browser pages. and redirect user directly to feature specific modals. we need to delay highlighting the user bar for later sessions.
@deeppandya deeppandya added QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels Jun 19, 2023
@brave-builds brave-builds added this to the 1.55.x - Nightly milestone Jun 30, 2023
@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 11, 2023
@Uni-verse
Copy link
Contributor

Uni-verse commented Sep 11, 2023

Verified on Samsung Galaxy S21 using version:

Brave	1.58.117 Chromium: 116.0.5845.180 (Official Build) (64-bit) 
Revision	99255ad6abf2fa399c063683c051f973e1f5c0af
OS	Android 13; Build/TP1A.220624.014; 33; REL

Using Test Plan in brave/brave-core#19107 (comment)

VPN

  • Ensured deep link for VPN will take user to the app store brave page and installing/opening the app will take user to VPN subscription screen.
  • Ensured that user is presented with default browser + P3A onboarding screens.
  • Ensured that when app is installed, using the deep link will just open the app.

Playlist

  • Ensured deep link for Playlist will take user to the play store brave download page and installing/opening the app will take user to playlist screens.
  • Ensured that user is presented with default browser + P3A onboarding screens.
  • Ensured that when app is installed, using the deep link will just open the app.
Example Example Example Example Example Example
Screenshot 2023-09-11 at 5 44 05 PM Screenshot 2023-09-11 at 5 45 07 PM Screenshot 2023-09-12 at 9 56 50 AM Screenshot 2023-09-12 at 9 56 53 AM Screenshot 2023-09-12 at 9 56 56 AM Screenshot 2023-09-11 at 5 46 12 PM
Example Example Example Example Example Example Example Example
Screenshot 2023-09-11 at 5 45 07 PM Screenshot 2023-09-12 at 9 56 50 AM Screenshot 2023-09-12 at 9 56 53 AM Screenshot 2023-09-12 at 9 56 56 AM Screenshot 2023-09-12 at 10 18 41 AM Screenshot 2023-09-12 at 10 18 45 AM Screenshot 2023-09-12 at 10 18 48 AM Screenshot 2023-09-12 at 10 18 54 AM

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy Tab S7 using version(s):

Brave	1.58.117 Chromium: 116.0.5845.180 (Official Build) (64-bit) 
Revision	99255ad6abf2fa399c063683c051f973e1f5c0af
OS	Android 13; Build/TP1A.220624.014; 33; REL

Using Test Plan in brave/brave-core#19107 (comment)

VPN

  • Ensured deep link for VPN will take user to the app store brave page and installing/opening the app will take user to VPN subscription screen.
  • Ensured that user is presented with default browser + P3A onboarding screens.
  • Ensured that when app is installed, using the deep link will just open the app.

Playlist

  • Ensured deep link for Playlist will take user to the play store brave download page and installing/opening the app will take user to playlist screens.
  • Ensured that user is presented with default browser + P3A onboarding screens.
  • Ensured that when app is installed, using the deep link will just open the app.
VPNPlaylist
deeplink_vpn1.mp4
deeplink_playlist2.mp4

@Uni-verse Uni-verse added QA Pass - Android Tab and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 12, 2023
@deeppandya deeppandya reopened this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants