Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap page available for locked wallet #31236

Closed
vadimstruts opened this issue Jun 22, 2023 · 1 comment · Fixed by brave/brave-core#18998
Closed

Swap page available for locked wallet #31236

vadimstruts opened this issue Jun 22, 2023 · 1 comment · Fixed by brave/brave-core#18998
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include

Comments

@vadimstruts
Copy link
Collaborator

Description

Swap page allows to see account balances without wallet to be unlocked

Steps to Reproduce

  1. Unlock wallet
  2. Go to swap page
  3. Close the browser by clicking "Exit"
  4. Open browser

Actual result:

You can see balance for the accounts

Expected result:

No swap page opened (just blank screen)

Reproduces how often:

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@vadimstruts vadimstruts added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality labels Jun 22, 2023
@vadimstruts vadimstruts self-assigned this Jun 22, 2023
@brave-builds brave-builds added this to the 1.55.x - Nightly milestone Jun 23, 2023
@srirambv
Copy link
Contributor

Verification passed on Oppo reno 5 with Android 13 running 1.58.117 x64 build

31236.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants