Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape character showing up on rewards text info #3131

Closed
srirambv opened this issue Jan 28, 2019 · 5 comments
Closed

Escape character showing up on rewards text info #3131

srirambv opened this issue Jan 28, 2019 · 5 comments
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@srirambv
Copy link
Contributor

Description

Escape character showing up on rewards text info

Steps to Reproduce

  1. Install 0.59.31
  2. Enable rewards
  3. Go to backup wallet. Escape string shows up in the text

Actual result:

image

Expected result:

Shouldn't contain escape character in the text block

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.59.31 Chromium: 72.0.3626.71 (Official Build) (64-bit)
Revision f52ccad2a6a3c65fc9e0c591a517ceab1198dac0-refs/branch-heads/3626@{#763}
OS Linux

Reproducible on current release:

  • No on the current release build it shows duplicate text but there was no escape character shown
    image

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @brave/legacy_qa to verify on other platforms

@srirambv srirambv added needs-text-change This change requires some careful wording. feature/rewards priority/P3 The next thing for us to work on. It'll ride the trains. release/not-blocking release-notes/exclude regression labels Jan 28, 2019
@srirambv srirambv added this to the 1.x Backlog milestone Jan 28, 2019
@srirambv
Copy link
Contributor Author

Not a regression as the escape string is visible on the duplicate text block as well.

@kjozwiak
Copy link
Member

Not a regression as the escape string is visible on the duplicate text block as well.

Yup, you can see the same issue in the screenshots under #2446. We really need to fix #2446 which would most likely also fix this issue.

@srirambv
Copy link
Contributor Author

#2446 seem to have been fixed on 0.59.x but need to find out which PR fixed it so that the issue can be closed and marked as verified cc: @NejcZdovc

@NejcZdovc NejcZdovc removed their assignment Jan 29, 2019
@NejcZdovc
Copy link
Contributor

dupe of #2693

@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Jan 29, 2019
@NejcZdovc NejcZdovc added closed/duplicate Issue has already been reported and removed release-notes/exclude release/not-blocking priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 29, 2019
@srirambv srirambv removed QA/Yes needs-text-change This change requires some careful wording. feature/rewards labels Jan 29, 2019
@btlechowski
Copy link

Reproduced on Windows 7

Brave 0.59.31 Chromium: 72.0.3626.71 (Official Build) (64-bit)
Revision f52ccad2a6a3c65fc9e0c591a517ceab1198dac0-refs/branch-heads/3626@{#763}
OS Windows 7

image

@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Development

No branches or pull requests

5 participants