Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global shields are applied to local files #3140

Closed
btlechowski opened this issue Jan 29, 2019 · 1 comment
Closed

global shields are applied to local files #3140

btlechowski opened this issue Jan 29, 2019 · 1 comment

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. Open brave://settings/?search=Script+blocking
  2. Turn Script Blocking on
  3. Open(CTRL+O) this file: test_block_script.zip

Actual result:

Page shows FAIL
Script was blocked
Global shield setting are not applied to local files

image

Expected result:

Page shows PASS
Script was not blocked
Global shield setting should not apply to local files

Reproduces how often:

easily reproduced

Brave version (brave://version info)

Brave 0.59.31 Chromium: 72.0.3626.71 (Official Build) (64-bit)
Revision f52ccad2a6a3c65fc9e0c591a517ceab1198dac0-refs/branch-heads/3626@{#763}
OS Windows 7
Brave 0.59.31 Chromium: 72.0.3626.71 (Official Build) (64-bit)
Revision f52ccad2a6a3c65fc9e0c591a517ceab1198dac0-refs/branch-heads/3626@{#763}
OS Linux
Brave 0.60.17 Chromium: 72.0.3626.64 (Official Build) dev (64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Windows 7

cc @brave/legacy_qa @tomlowenthal

@btlechowski btlechowski added feature/shields The overall Shields feature in Brave. feature/global-settings Settings at browser level independent of shields settings QA/Yes QA/Test-Plan-Specified labels Jan 29, 2019
@btlechowski btlechowski added this to the 1.x Backlog milestone Jan 29, 2019
@tildelowengrimm
Copy link
Contributor

Global shields settings are supposed to apply to the file:// protocol as well as the regular web.

@tildelowengrimm tildelowengrimm modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Jan 31, 2019
@kjozwiak kjozwiak added closed/invalid and removed QA/Test-Plan-Specified QA/Yes closed/not-actionable feature/global-settings Settings at browser level independent of shields settings feature/shields The overall Shields feature in Brave. labels Feb 5, 2019
@rebron rebron removed this from the Dupe / Invalid / Not actionable milestone May 8, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants