You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-up for #3176 BraveNetworkDelegateBase listens for updates of the referral headers list, but this is actually not needed. Since the list is a global for the whole app we can just get it when needed.
This way, we can remove unsafe usages of base::Unretained in BraveNetworkDelegateBase. To safely get the list on IO thread, I'd suggest to keep a copy of a the list (or a single instance if nobody wants it on other threads) and atomically update this copy during updates
Follow-up for #3176
BraveNetworkDelegateBase
listens for updates of the referral headers list, but this is actually not needed. Since the list is a global for the whole app we can just get it when needed.This way, we can remove unsafe usages of
base::Unretained
inBraveNetworkDelegateBase
. To safely get the list on IO thread, I'd suggest to keep a copy of a the list (or a single instance if nobody wants it on other threads) and atomically update this copy during updatesBrave version (brave://version info)
.
The text was updated successfully, but these errors were encountered: