Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling an unapproved transaction continues to show the pending transaction icon #32199

Closed
srirambv opened this issue Aug 11, 2023 · 2 comments · Fixed by brave/brave-core#19733
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Cancelling an unapproved transaction continues to show the pending transaction icon

Steps to reproduce

  1. Create a send transaction
  2. Close the approval screen to keep the transaction in unapproved state
  3. Go to Activity tab and click the unapproved transaction
  4. Reject the transaction
  5. Pending transaction bell icon is still shown
  6. Click the transaction bell icon, shows the rejected transaction
  7. Reject the transaction again, removes the pending transaction icon

Actual result

Reject.Transaction.mp4

Expected result

Should not show pending transaction if the transaction is already rejected

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Maybe

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 13

Brave version

1.57.44

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @Pavneet-Sing @simoarpe

@kjozwiak
Copy link
Member

The above requires 1.57.53 or higher for 1.57.x verification 👍

@srirambv
Copy link
Contributor Author

Verification passed on Oppo Reno 5 with Android 13 running 1.57.53 x64 build

  • Verified steps from issue description
  • Verified pending transaction button is dismissed when a transaction is submitted
32199.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants