Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] By default enable the "allow links to open in apps outside of Brave" setting #32500

Closed
timchilds opened this issue Aug 24, 2023 · 4 comments · Fixed by brave/brave-core#19875
Closed

[Android] By default enable the "allow links to open in apps outside of Brave" setting #32500

timchilds opened this issue Aug 24, 2023 · 4 comments · Fixed by brave/brave-core#19875
Assignees
@deeppandya
Labels
enhancement OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.57.x - Release #5

Comments

@timchilds
Copy link

timchilds commented Aug 24, 2023 •
edited
Loading

Description

The allow links to open in apps outside of Brave setting is current disabled by default on Android (app links will not open outside Brave).

This is causing some user confusion/issues, see slack thread here:
https://bravesoftware.slack.com/archives/C0816QH3R/p1692901085393929

We should change the default to enabled to match the Brave iOS app. At least until we create app-level options.
@timchilds timchilds added the OS/Android Fixes related to Android browser functionality label Aug 24, 2023
@timchilds timchilds mentioned this issue Aug 24, 2023
Closed
@deeppandya deeppandya mentioned this issue Aug 25, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.59.x - Nightly milestone Aug 25, 2023
This was referenced Aug 25, 2023
Merged
Merged
@kjozwiak
Copy link
Member

@Uni-verse @vlad-hoff STR/Cases can be found via brave/brave-core#19875 (comment) 👍 I would recommend adding a few other app links just in case. I basically just used GPS for a quick check on Nighty before uplifting into 1.58.x & 1.57.x.

@kjozwiak
Copy link
Member

The above requires 1.57.56 or higher for 1.57.x verification 👍

@kjozwiak kjozwiak mentioned this issue Aug 29, 2023
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Aug 29, 2023 •
edited
Loading

@Uni-verse @vlad-hoff just a heads up that the upgrade case is not working as expected until #32586 is fixed/uplifted into 1.57.x. CCing @deeppandya @anthonypkeane.

@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 30, 2023
@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 5G using version:

Brave	1.57.57 Chromium: 116.0.5845.163 (Official Build) (64-bit) 
Revision	d85db1f5df3b20ffecf96ab3f0dc7fca1d536955
OS	Android 13; Build/TP1A.220624.014; 33; REL
first launch search results opened in external app disable feature opened in brave Waze Waze (feature disabled)
Screenshot 2023-08-30 at 10 55 31 AM Screenshot 2023-08-30 at 10 56 20 AM Screenshot 2023-08-30 at 10 56 34 AM Screenshot 2023-08-30 at 10 57 38 AM Screenshot 2023-08-30 at 10 57 03 AM Screenshot 2023-08-30 at 11 44 59 AM Screenshot 2023-08-30 at 11 45 43 AM

@Uni-verse Uni-verse added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 30, 2023
This was referenced Aug 30, 2023
Closed
Closed
@bsclifton bsclifton mentioned this issue Sep 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
enhancement OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Milestone
1.57.x - Release #5
Development

Successfully merging a pull request may close this issue.

Enable external app link by default brave/brave-core
5 participants
@kjozwiak @deeppandya @Uni-verse @timchilds @brave-builds