Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak portfolio UI and add option to show hidden NFTs #32545

Closed
simoarpe opened this issue Aug 28, 2023 · 2 comments · Fixed by brave/brave-core#19990
Closed

Tweak portfolio UI and add option to show hidden NFTs #32545

simoarpe opened this issue Aug 28, 2023 · 2 comments · Fixed by brave/brave-core#19990
Assignees
@simoarpe
Labels
blocked feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.59.x - Release

Comments

@simoarpe
Copy link

Description

Tweak UI

  • Remove bounce effect from bottom navigation view
  • Remove indicator from bottom navigation view
  • Change color for selected section in bottom navigation view
  • Increase top padding of chip tab layout at the top
  • Modify background color of chip tab layout into darker gray (check Figma)

Hidden NFTs

Add an option in the action bar to show/hide hidden NFTs in the NFT section
@simoarpe simoarpe added priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Aug 28, 2023
@simoarpe simoarpe self-assigned this Aug 28, 2023
@simoarpe simoarpe mentioned this issue Aug 24, 2023
Closed
@simoarpe simoarpe mentioned this issue Sep 5, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.59.x - Nightly milestone Sep 6, 2023
@srirambv
Copy link
Contributor

Currently blocked on #33255

@srirambv
Copy link
Contributor

srirambv commented Oct 9, 2023

Verification passed on Oppo Reno 5 with Android 13 running 1.59.115 x64 build

  • Verified steps from brave/brave-core#19990
  • Verified no bounce effect is shown on navigation
  • Verified bottom navigation is now shown in single colour
  • Verified able to show/hide NFTs
  • Additional verification here

@kjozwiak kjozwiak mentioned this issue Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoarpe simoarpe

Labels
blocked feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.59.x - Release
Development

Successfully merging a pull request may close this issue.

Tweak portfolio UI and add option to show hidden NFTs brave/brave-core
3 participants
@simoarpe @srirambv @brave-builds