Opening external links in the same tab groups stopped working

[samartnik]

Description

Opening external links in the same tab groups stopped working.

Steps to reproduce

1. Make sure Only open links in current tab group option is on.
2. Try to open external link.
3. It opens in a different tab group (see example https://bravesoftware.slack.com/archives/C0816QH3R/p1694170188294899)

Actual result

Link opens in new tab group.

Expected result

Link opens in the same tab group.

Issue reproduces how often

Always for me, but other devs reported it to be working on their devices.

Version/Channel Information:

• Can you reproduce this issue with the current Play Store version? yes
• Can you reproduce this issue with the current Play Store Beta version? no, it is fixed in cr117
• Can you reproduce this issue with the current Play Store Nightly version? no, it is fixed in cr117

Device details

• Install type (ARM, x86):
• Device type (Phone, Tablet, Phablet):
• Android version:

Brave version

1.57.x and 1.58.x

Website problems only

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Additional information

[kjozwiak]

Closing as the above has been fixed via brave/brave-core@145681c as per brave/brave-core#20069 (comment) & brave/brave-core#20070 (comment).

[kjozwiak]

As per brave/brave-core#20069 (review), the above can be verified with 1.58.120 as per the conversation via https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1694459339315069.

[Uni-verse]

Verified on Samsung Galaxy S21 using version:

Brave	1.58.120 Chromium: 117.0.5938.48 (Official Build) (32-bit) 
Revision	8b2e2785c90c076fc1413acb2c003e603eac02d3
OS	Android 13; Build/TP1A.220624.014; 33; REL

Test Scenario:

1. New profile
2. Confirm tab groups are enabled in appearance settings
3. Navigate to webpage and open in new tab group using context menu
4. Repeat again, confirm its opened in same tab group
5. Confirm using open in new tab will still open in another tab

newtabgroup1.mp4