Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Add save path to bookmark exported successfully dialog #33171

Closed
timchilds opened this issue Sep 21, 2023 · 2 comments · Fixed by brave/brave-core#20366
Closed

[Android] Add save path to bookmark exported successfully dialog #33171

timchilds opened this issue Sep 21, 2023 · 2 comments · Fixed by brave/brave-core#20366
Assignees

Comments

@timchilds
Copy link

timchilds commented Sep 21, 2023

Description

Problem: some users are unable to find where we export bookmarks.
https://community.brave.com/t/export-and-import-feature-on-android-app/506777

Solution: show the export path in the dialog. Make it tappable to open folder in default files app (if possible).

image

@timchilds timchilds added OS/Android Fixes related to Android browser functionality enhancement feature/bookmarks QA/Yes labels Sep 21, 2023
@SergeyZhukovsky SergeyZhukovsky added release-notes/include priority/P3 The next thing for us to work on. It'll ride the trains. labels Oct 3, 2023
@brave-builds brave-builds added this to the 1.61.x - Nightly milestone Oct 11, 2023
@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 17, 2023
@Uni-verse
Copy link
Contributor

Uni-verse commented Nov 17, 2023

Verified on Samsung Galaxy S21 using version:

Brave	1.61.77 Chromium: 119.0.6045.163 (Official Build) beta (64-bit) 
Revision	d0b89bdae9ecff96899c68447dae4a2c45c51e2a
OS	Android 13; Build/TP1A.220624.014; 33; REL
  • Ensured that export path is shown in the Export successful message.
  • Ensured that confirmation message closes when tapping Close button.
  • Ensured that tapping Open folder will open files explorer view.
  • Ensured that bookmarks are successfully downloaded to the path location.
  • Ensured that selecting Always Open for app selection will successfully export bookmarks next time without the prompt.

Export Flow

Example Example Example
Screenshot 2023-11-17 at 2 10 49 PM Screenshot 2023-11-17 at 2 11 12 PM Screenshot 2023-11-17 at 2 23 39 PM

Import Flow

Example Example Example
Screenshot 2023-11-17 at 2 28 32 PM Screenshot 2023-11-17 at 2 29 58 PM Screenshot 2023-11-17 at 2 30 12 PM
Example Example
Screenshot 2023-11-17 at 2 10 49 PM Screenshot 2023-11-17 at 2 46 38 PM

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy Tab S7 using version:

Brave	1.61.97 Chromium: 120.0.6099.56 (Official Build) (64-bit) 
Revision	06ca6e12ac1f53536386f61c923915da7d128e75
OS	Android 13; Build/TP1A.220624.014; 33; REL
  • Ensured that export path is shown in the Export successful message.
  • Ensured that confirmation message closes when tapping Close button.
  • Ensured that tapping Open folder will open files explorer view.
  • Ensured that bookmarks are successfully downloaded to the path location.
  • Ensured that selecting Always Open for app selection will successfully export bookmarks next time without the prompt.

Export flow

Example Example Example Example
Screenshot 2023-12-05 at 12 32 35 PM Screenshot 2023-12-05 at 12 32 40 PM Screenshot 2023-12-05 at 12 32 50 PM Screenshot 2023-12-05 at 12 32 57 PM

Import flow

Example Example Example Example
Screenshot 2023-12-05 at 1 19 06 PM Screenshot 2023-12-05 at 1 19 23 PM Screenshot 2023-12-05 at 1 19 32 PM Screenshot 2023-12-05 at 1 19 42 PM

Orientation & Appearance

Landscape Portrait
Screenshot 2023-12-05 at 1 27 34 PM Screenshot 2023-12-05 at 1 27 38 PM
Screenshot 2023-12-05 at 1 27 26 PM Screenshot 2023-12-05 at 1 27 05 PM

@Uni-verse Uni-verse added QA Pass - Android Tab and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants