Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GA4's cross-domain measurement query parameter #33188

Closed
fmarier opened this issue Sep 22, 2023 · 3 comments
Closed

Remove GA4's cross-domain measurement query parameter #33188

fmarier opened this issue Sep 22, 2023 · 3 comments
Assignees
@fmarier
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". privacy/query-filter QA Pass - Android ARM QA Pass-macOS QA/Yes release-notes/include
Milestone
1.60.x - Release

Comments

@fmarier
Copy link
Member

fmarier commented Sep 22, 2023 •
edited
Loading

Google Analytics 4 uses the _gl query string parameter in order to sync first-party cookies across different domains owned by the same entity: https://support.google.com/analytics/answer/10071811

These first party cookies include unique identifiers such as client IDs and session IDs: https://www.youtube.com/watch?v=LA2dPVj5y4Y

Therefore this is cross-site user tracking and so it's in scope for our query string filter.
@fmarier fmarier added priority/P4 Planned work. We expect to get to it "soon". OS/Android Fixes related to Android browser functionality OS/Desktop privacy/query-filter labels Sep 22, 2023
@fmarier fmarier self-assigned this Sep 22, 2023
@fmarier fmarier mentioned this issue Sep 22, 2023
Merged
25 tasks
@fmarier
Copy link
Member Author

fmarier commented Sep 22, 2023

Sample URLs:

@fmarier fmarier added this to the 1.60.x - Nightly milestone Sep 22, 2023
@stephendonner
Copy link

stephendonner commented Oct 4, 2023 •
edited
Loading

Verification PASSED using

Brave | 1.60.79 Chromium: 118.0.5993.32 (Official Build) nightly (x86_64)
-- | --
Revision | 95cf2d4e2e2855bd58fe8002ccd32e3d673abafd
OS | macOS Version 11.7.10 (Build 20G1427)

Steps:

  1. installed 1.60.79
  2. launched Brave
  3. confirmed Standard set for Trackers & ads blocking in brave://settings/shields
  4. opened https://brave.com/?at_recipient_id=1234&at_recipient_list=5678&unicorn_click_id=abcde&_gl=abc123

Confirmed that the URL bar only shows https://brave.com/

example example
Screen Shot 2023-10-04 at 7 56 55 PM Screen Shot 2023-10-04 at 7 58 42 PM

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 23, 2023
@hffvld
Copy link
Contributor

hffvld commented Oct 23, 2023

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 U1B1.230908.003 release-keys]
Brave build: 1.60.96 
Chromium: 118.0.5993.88 (Official Build) beta (64-bit) 
Revision: b4c059ad1d32d6e0cd1466123f03ccb97b3cf858

STEPS:

  1. Follow the steps from Add more query string parameters to our list brave-core#20254 (comment)

ACTUAL RESULTS:

  • Verified that the URL search bar contains only https://brave.com/
  • Verified the same by copy & paste the link and by opening the link from another app
1 2
1 2
2023-10-23_16-23-39.mp4

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 23, 2023
@LaurenWags LaurenWags mentioned this issue Nov 1, 2023
Closed
@kjozwiak kjozwiak mentioned this issue Nov 17, 2023
Closed
lyubomyr-shaydariv added a commit to lyubomyr-shaydariv/uu-webext that referenced this issue Jun 15, 2024
@lyubomyr-shaydariv
https://github.com/brave/brave-browser/issues/33188
1172a11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmarier fmarier

Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". privacy/query-filter QA Pass - Android ARM QA Pass-macOS QA/Yes release-notes/include
Projects
Security & Privacy
Status: Completed
Milestone
1.60.x - Release
Development

No branches or pull requests
3 participants
@fmarier @stephendonner @hffvld