Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in BraveNewTabPageLayout.java #33385

Closed
SergeyZhukovsky opened this issue Oct 3, 2023 · 1 comment · Fixed by brave/brave-core#20383
Closed

Crash in BraveNewTabPageLayout.java #33385

SergeyZhukovsky opened this issue Oct 3, 2023 · 1 comment · Fixed by brave/brave-core#20383
Assignees
@tapanmodh
Labels
crash feature/brave-news formerly brave-today OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include
Milestone
1.59.x - Release #2

Comments

@SergeyZhukovsky
Copy link
Member

I found that crash in a backtrace on a stable 1.58.135 channel. We should fix it and uplift to the stable channel.

java.lang.NullPointerException: Attempt to invoke virtual method 'void org.chromium.brave_news.mojom.BraveNewsController_Internal$Proxy.getFeed(org.chromium.brave_news.mojom.BraveNewsController$GetFeed_Response)' on a null object reference
        at org.chromium.chrome.browser.ntp.BraveNewTabPageLayout.lambda$getFeed$10(BraveNewTabPageLayout.java:901)
@SergeyZhukovsky SergeyZhukovsky added crash priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include OS/Android Fixes related to Android browser functionality feature/brave-news formerly brave-today labels Oct 3, 2023
@deeppandya
Copy link

Assigning @tapanmodh as it seems to be related to news

@tapanmodh tapanmodh mentioned this issue Oct 4, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.61.x - Nightly milestone Oct 10, 2023
This was referenced Oct 16, 2023
Merged
Merged
@kjozwiak kjozwiak mentioned this issue Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tapanmodh tapanmodh

Labels
crash feature/brave-news formerly brave-today OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include
Projects
None yet
Milestone
1.59.x - Release #2
Development

Successfully merging a pull request may close this issue.

[Android] fix crash in BraveNewTabPageLayout from gps brave/brave-core
4 participants
@deeppandya @tapanmodh @SergeyZhukovsky @brave-builds