Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 118.0.5993.70 to Chromium 118.0.5993.88 #33694

Closed
emerick opened this issue Oct 17, 2023 · 5 comments · Fixed by brave/brave-core#20575
Closed

Upgrade from Chromium 118.0.5993.70 to Chromium 118.0.5993.88 #33694

emerick opened this issue Oct 17, 2023 · 5 comments · Fixed by brave/brave-core#20575
Assignees
@emerick @mkarolin
Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-macOS-arm64 QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.59.x - Release #2

Comments

@emerick
Copy link
Contributor

emerick commented Oct 17, 2023

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/118.0.5993.70..118.0.5993.88?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@emerick emerick added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Desktop labels Oct 17, 2023
This was referenced Oct 17, 2023
Merged
Merged
Merged
@brave-builds brave-builds added this to the 1.60.x - Beta milestone Oct 18, 2023
@btlechowski
Copy link

btlechowski commented Oct 18, 2023 •
edited by GeetaSarvadnya
Loading

Verified with

Brave 1.59.120 Chromium: 118.0.5993.88 (Official Build) (64-bit)
Revision 135f92a9af2134bc7d7aeba82f87ff5e68669410
OS Linux

image

Verification PASSED on

Brave | 1.59.120 Chromium: 118.0.5993.88 (Official Build) (64-bit)
-- | --
Revision | 135f92a9af2134bc7d7aeba82f87ff5e68669410
OS | Windows 10 Version 22H2 (Build 19045.3570)

image

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 using version:

Brave	1.59.120 Chromium: 118.0.5993.88 (Official Build) (64-bit) 
Revision	135f92a9af2134bc7d7aeba82f87ff5e68669410
OS	Android 13; Build/TP1A.220624.014; 33; REL
  • Version bump
  • Branding
Example Example
Screenshot 2023-10-18 at 10 15 34 AM Screenshot 2023-10-18 at 10 22 52 AM

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy Tab S7 using version:

Brave	1.59.120 Chromium: 118.0.5993.88 (Official Build) (64-bit) 
Revision	135f92a9af2134bc7d7aeba82f87ff5e68669410
OS	Android 13; Build/TP1A.220624.014; 33; REL
  • Version bump
  • Branding
Example Example
Screenshot 2023-10-18 at 10 37 19 AM Screenshot 2023-10-18 at 10 37 34 AM

@kjozwiak kjozwiak mentioned this issue Oct 18, 2023
Closed
@kjozwiak
Copy link
Member

Verification PASSED on macOS 14.0 Sonoma x64 using the following build(s):

Brave | 1.59.120 Chromium: 118.0.5993.88 (Official Build) (x86_64)
--- | ---
Revision | 135f92a9af2134bc7d7aeba82f87ff5e68669410
OS | macOS Version 14.0 (Build 23A344)

Screenshot 2023-10-18 at 2 00 11 PM

@stephendonner
Copy link

Verified PASSED using

Brave | 1.59.120 Chromium: 118.0.5993.88 (Official Build) (arm64)
-- | --
Revision | 135f92a9af2134bc7d7aeba82f87ff5e68669410
OS | macOS Version 13.6 (Build 22G120)
Screenshot 2023-10-18 at 11 50 35 AM

@kjozwiak kjozwiak mentioned this issue Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

@mkarolin mkarolin

Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-macOS-arm64 QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.59.x - Release #2
Development

Successfully merging a pull request may close this issue.

Upgrade from Chromium 118.0.5993.70 to Chromium 118.0.5993.88 brave/brave-core
8 participants
@stephendonner @kjozwiak @emerick @Uni-verse @btlechowski @GeetaSarvadnya @mkarolin @brave-builds