You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On debug builds, a NOTREACHED(); is hit after restoring a wallet and immediately locking the wallet.
Hit on iOS, but I can reproduce using 1.59.x, 1.60.x and master of brave-core repo. Theory in Miscellaneous Information below.
Description
On debug builds, a
NOTREACHED();
is hit after restoring a wallet and immediately locking the wallet.Hit on iOS, but I can reproduce using
1.59.x
,1.60.x
andmaster
ofbrave-core
repo. Theory inMiscellaneous Information
below.Steps to Reproduce
NOTREACHED();
: https://github.com/brave/brave-core/blob/master/components/brave_wallet/browser/account_discovery_manager.cc#L74Actual result:
Crashes
Expected result:
Does not crash
Reproduces how often:
Easily reproduced (on iOS)
Brave version (brave://version info)
1.59+
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
I suspect this is a race condition but I've not fully debugged it.
NOTREACHED
is hit inaccount_discovery_manager.cc
at L74:https://github.com/brave/brave-core/blob/fffea2b96c7bc255a66101166461cfe7b1d81fdb/components/brave_wallet/browser/account_discovery_manager.cc#L74
This can be hit when
KeyringService::GetDiscoveryAddress
returns null:https://github.com/brave/brave-core/blob/fffea2b96c7bc255a66101166461cfe7b1d81fdb/components/brave_wallet/browser/keyring_service.cc#L1753-L1758
KeyringService::GetDiscoveryAddress
can return null whenKeyringService::GetHDKeyringById
returns null:https://github.com/brave/brave-core/blob/fffea2b96c7bc255a66101166461cfe7b1d81fdb/components/brave_wallet/browser/keyring_service.cc#L1429-L1434
KeyringService::GetHDKeyringById
returns null when_keyrings
does not contain the keyring for the given id._keyrings
is cleared when wallet is locked:https://github.com/brave/brave-core/blob/fffea2b96c7bc255a66101166461cfe7b1d81fdb/components/brave_wallet/browser/keyring_service.cc#L1930
The text was updated successfully, but these errors were encountered: