Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generic linking error text #33955

Closed
Miyayes opened this issue Oct 27, 2023 · 7 comments · Fixed by brave/brave-core#21863
Closed

Update generic linking error text #33955

Miyayes opened this issue Oct 27, 2023 · 7 comments · Fixed by brave/brave-core#21863
Assignees
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-macOS QA/Yes release-notes/include

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Oct 27, 2023

Current

image

New text

Something went wrong

We weren’t able to complete your request. Please try again, and contact support if the problem persists.

(Close)


Edit: Originally we would also display (Error code: {{HTTP_STATUS_CODE}}) , but it's nontrivial to do that, so scoping it out for now.

@Miyayes Miyayes added feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop labels Oct 27, 2023
@Miyayes Miyayes added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 10, 2023
@Miyayes
Copy link
Collaborator Author

Miyayes commented Nov 10, 2023

@emerick Is it possible to put the HTTP status code here? It'll give us some sense of what the issue is without having to collect full logs.

@Miyayes Miyayes changed the title Update generic linking error text Update generic linking error text and display error code Nov 10, 2023
@emerick
Copy link
Contributor

emerick commented Nov 10, 2023

Should be doable, we just have to make sure to pass it through.

@mkarolin
Copy link
Contributor

If I am looking at the code correctly, in order to get the http status code into the UI, we'd have to save it during post-connect, which happens in the engine, then pass it into rewards service with the connection result via mojom interface. That seems like quite a few changes. How badly do we need it in the UI, @Miyayes 😄 cc: @zenparsing: is there an easier way?

@Miyayes
Copy link
Collaborator Author

Miyayes commented Jan 30, 2024

@mkarolin Sounds like it's too heavy. Unless there's a simple lightweight solution, let's just pare this down and do the text change and we can defer the status code part.

@zenparsing
Copy link

@mkarolin Sorry, didn't see your question before. I think it would be great to provide more context, but as you say it's complicated.

@Miyayes Miyayes changed the title Update generic linking error text and display error code Update generic linking error text Feb 2, 2024
@mkarolin mkarolin added this to the 1.64.x - Nightly milestone Feb 2, 2024
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 1, 2024
@LaurenWags
Copy link
Member

LaurenWags commented Mar 1, 2024

Verified with

Brave | 1.64.90 Chromium: 122.0.6261.94 (Official Build) beta (x86_64)
-- | --
Revision | 726c6970a1e9c057c69d80e03ad95a7c561fbfe7
OS | macOS Version 13.6.4 (Build 22G513)

HTTP error code not included, will be added with #35781.

Compared error message for HTTP 500 on both 1.63.x and 1.64.x.
Confirmed updated text in 1.64.x.
Confirmed "contact support" link directs to community.brave.com as expected.
Confirmed able to close the error modal via the "Close" and "x" buttons.

1.63.x 1.64.x
1 63 x 1 64 x

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 4, 2024
@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 6, 2024
@Uni-verse
Copy link
Contributor

Uni-verse commented Mar 6, 2024

Verified on Samsung Galaxy S21 using version:

Brave	1.64.95 Chromium: 122.0.6261.94 (Official Build) beta (64-bit) 
Revision	6f4193fbcee7c358ae3684f777faa9f12e52206e
OS	Android 13; Build/TP1A.220624.014; 33; REL
  • Ensured copy for status code 500 error is updated.
  • Ensured contact support will open support page.
  • Ensured message can be dismissed by the user.
Example Example
Screenshot 2024-03-06 at 5 51 51 PM Screenshot 2024-03-06 at 5 52 07 PM

@Uni-verse Uni-verse added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-macOS QA/Yes release-notes/include
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants