-
Notifications
You must be signed in to change notification settings - Fork 2.3k
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update generic linking error text #33955
Comments
@emerick Is it possible to put the HTTP status code here? It'll give us some sense of what the issue is without having to collect full logs. |
Should be doable, we just have to make sure to pass it through. |
If I am looking at the code correctly, in order to get the http status code into the UI, we'd have to save it during post-connect, which happens in the engine, then pass it into rewards service with the connection result via mojom interface. That seems like quite a few changes. How badly do we need it in the UI, @Miyayes 😄 cc: @zenparsing: is there an easier way? |
@mkarolin Sounds like it's too heavy. Unless there's a simple lightweight solution, let's just pare this down and do the text change and we can defer the status code part. |
@mkarolin Sorry, didn't see your question before. I think it would be great to provide more context, but as you say it's complicated. |
Verified with
HTTP error code not included, will be added with #35781. Compared error message for
|
Current
New text
Something went wrong
We weren’t able to complete your request. Please try again, and contact support if the problem persists.
(Close)
Edit: Originally we would also display (Error code:
{{HTTP_STATUS_CODE}}
) , but it's nontrivial to do that, so scoping it out for now.The text was updated successfully, but these errors were encountered: