Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problematic first party elements are not blocked by Shields in Standard mode #34081

Closed
antonok-edm opened this issue Nov 3, 2023 · 3 comments · Fixed by brave/brave-core#20826
Closed

Problematic first party elements are not blocked by Shields in Standard mode #34081

antonok-edm opened this issue Nov 3, 2023 · 3 comments · Fixed by brave/brave-core#20826
Assignees
@antonok-edm
Labels
bug feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.60.x - Release #2

Comments

@antonok-edm
Copy link
Collaborator

This was previously fixed in brave/brave-core#19946, but since that was reverted it has come up again on a few sites such as:

  • dailymail.co.uk

image

  • imdb.com

image

  • politico.com

image
@antonok-edm antonok-edm added bug feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 3, 2023
@antonok-edm antonok-edm self-assigned this Nov 3, 2023
@antonok-edm antonok-edm mentioned this issue Nov 3, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.62.x - Nightly milestone Nov 3, 2023
This was referenced Nov 3, 2023
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Nov 6, 2023

The above requires 1.60.114 or higher for 1.60.x verification 👍

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 8, 2023 •
edited
Loading

Verification PASSED on

Brave | 1.60.114 Chromium: 119.0.6045.124 (Official Build) (64-bit)
-- | --
Revision | 99a34933fc6a44fdfe52dea41341927bbce3549a
OS | Windows 10 Version 22H2 (Build 19045.3570)

dailymail.co.uk

Example Example
image image

imdb.com

Example Example
image image

politico.com

Example Example
image image

This was referenced Nov 8, 2023
Closed
Closed
@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 using the following version:

Brave	1.60.116 Chromium: 119.0.6045.134 (Official Build) (32-bit) 
Revision	def53af41c7a126b2def06e7f6aa2063ad5364e7
OS	Android 13; Build/TP1A.220624.014; 33; REL
dailymail.co.uk imdb.com Politico.com
Screenshot 2023-11-09 at 11 20 08 AM Screenshot 2023-11-09 at 11 21 34 AM Screenshot 2023-11-09 at 11 22 39 AM

@kjozwiak kjozwiak mentioned this issue Nov 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonok-edm antonok-edm

Labels
bug feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.60.x - Release #2
Development

Successfully merging a pull request may close this issue.

Add first-party exception list to the correct adblock engine brave/brave-core
5 participants
@kjozwiak @Uni-verse @antonok-edm @GeetaSarvadnya @brave-builds