Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet Web UI/2.0 #34386

Closed
simoarpe opened this issue Nov 16, 2023 · 1 comment · Fixed by brave/brave-core#20635
Closed

Wallet Web UI/2.0 #34386

simoarpe opened this issue Nov 16, 2023 · 1 comment · Fixed by brave/brave-core#20635
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include security
Milestone
1.63.x - Release

Comments

@simoarpe
Copy link

simoarpe commented Nov 16, 2023 •
edited
Loading

Roadmap issue: https://github.com/brave/roadmap/issues/944
Security review issue: https://github.com/brave/reviews/issues/1455

Description

Implement WebUI to show main portfolio screen.
Screens/parts that will remain native:

  • Onboarding
  • Authentication
  • Transaction confirmations
@simoarpe simoarpe added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Nov 16, 2023
@simoarpe simoarpe mentioned this issue Nov 16, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.63.x - Nightly milestone Dec 7, 2023
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.63.157 x64 build

  • Verified Wallet WebUI is loaded when wallet is created and opening Wallet from menu
  • Verified onboarding still shows native Wallet UI for onboarding
  • Verified wallet routes work as expected on WebUI
  • Verified reset wallet and restoring wallet continues to use native UI
  • Verified submitting a transaction brings up native UI for transaction confirmation
  • Verified if no tab has brave://wallet route, unlocking loads native UI
Google Pixel 8 (Android 14) Lenovo Tab (Android 13)
34386-ARM.mp4
34386-Tab.mp4

@kjozwiak kjozwiak mentioned this issue Feb 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include security
Projects
Web3
Archived in project
Milestone
1.63.x - Release
Development

Successfully merging a pull request may close this issue.

(Wallet) Implement WebUI for main portfolio screen brave/brave-core
3 participants
@simoarpe @srirambv @brave-builds