Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Jupiter Swap API v6 #35091

Closed
onyb opened this issue Jan 2, 2024 · 2 comments · Fixed by brave/brave-core#21475
Closed

Migrate to Jupiter Swap API v6 #35091

onyb opened this issue Jan 2, 2024 · 2 comments · Fixed by brave/brave-core#21475
Assignees
@onyb
Labels
feature/web3/wallet/core feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.62.x - Release

Comments

@onyb
Copy link
Member

onyb commented Jan 2, 2024

🚨 Jupiter Swap API v4 will be discontinued by end of January 2024 per an announcement on their dev Telegram channel.

A few things about v6:

  • complex routing - up to 10% saving to users depending on the amount
  • performance improvement - from p99 > 4s to now sub 1s in v6

The PR needs to uplifted to 1.62.x to avoid disruption of service to users swapping on Solana.
@onyb onyb added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality OS/Desktop feature/web3/wallet/core feature/web3/wallet/swap labels Jan 2, 2024
@onyb onyb self-assigned this Jan 2, 2024
@onyb onyb mentioned this issue Jan 2, 2024
Merged
24 tasks
@StephenHeaps StephenHeaps mentioned this issue Jan 2, 2024
Closed
@brave-builds brave-builds added the feature/web3/wallet Integrating Ethereum+ wallet support label Jan 5, 2024
@brave-builds brave-builds added this to the 1.63.x - Nightly milestone Jan 5, 2024
@onyb onyb mentioned this issue Jan 5, 2024
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Jan 9, 2024

The above requires 1.62.136 or higher for 1.62.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.62.137 Chromium: 120.0.6099.217 (Official Build) beta (64-bit)
Revision 92c88bc64f4e5c37e60774394436493726ad7d63
OS Windows 11 Version 23H2 (Build 22631.3007)
  • Verified steps from brave/brave-core#21475
  • Verified multiple quote options are removed
  • Verified Swap work as expected
35091.mp4

Verification passed on Google Pixel 8 with Android 14 running 1.62.137 x64 Beta build

  • Verified steps from brave/brave-core#21475
  • Verified multiple quote options are removed
  • Verified Swap work as expected
35091.mp4

@LaurenWags LaurenWags mentioned this issue Jan 24, 2024
Closed
@kjozwiak kjozwiak mentioned this issue Jan 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet/core feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.62.x - Release
Development

Successfully merging a pull request may close this issue.

chore(wallet): migrate to Jupiter API v6 brave/brave-core
5 participants
@kjozwiak @onyb @srirambv @brave-builds and others