Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Instagram's new igsh share tracker #35094

Closed
fmarier opened this issue Jan 2, 2024 · 4 comments
Closed

Remove Instagram's new igsh share tracker #35094

fmarier opened this issue Jan 2, 2024 · 4 comments
Assignees
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy/query-filter QA Pass - Android ARM QA Pass-macOS QA/Yes release-notes/include

Comments

@fmarier
Copy link
Member

fmarier commented Jan 2, 2024

Similar to YouTube's sharing functionality which copies a URL along with a tracking parameter to the clipboard (#33037), Instagram adds an igsh parameter to the URLs that it copies to the clipboard in JS.

We should add it to our default filter and the copy clean link feature. Then, #33037 will end up sanitizing both YouTube and Instagram.

@fmarier fmarier added priority/P4 Planned work. We expect to get to it "soon". OS/Android Fixes related to Android browser functionality OS/Desktop privacy/query-filter labels Jan 2, 2024
@fmarier fmarier self-assigned this Jan 2, 2024
@fmarier
Copy link
Member Author

fmarier commented Jan 3, 2024

More info on why they track outbound links like that: https://help.instagram.com/2599848706833869

(HT https://twitter.com/gateklons/status/1739407333602533461)

@fmarier fmarier added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include and removed priority/P4 Planned work. We expect to get to it "soon". labels Jan 3, 2024
@fmarier
Copy link
Member Author

fmarier commented Jan 3, 2024

Here are two examples (parameter value shortened for privacy):

where the identifier appears to be stabled across logins for a given user.

Note that the igsh param is only added via the Share to... option and not when selecting Copy link directly from the first menu. Share to... (first menu) followed by Copy link (second menu) does append the parameter.

@fmarier fmarier changed the title Remove Instagram's new igsh share tracker Remove Instagram's new igsh share tracker Jan 3, 2024
@fmarier fmarier added this to the 1.63.x - Nightly milestone Jan 3, 2024
@stephendonner
Copy link

stephendonner commented Jan 8, 2024

Verified PASSED using

Brave | 1.63.101 Chromium: 120.0.6099.199 (Official Build) nightly (x86_64)
-- | --
Revision | 8d3f0a563e185b6a763cc8e210ab24775dfb9047
OS | macOS Version 14.3 (Build 23D5043d)

Case1 : https://www.youtube.com/watch?v=dQw4w9WgXcQ&si=YjziZuccJeIE-b6z - PASSED

Steps:

  1. installed 1.63.101
  2. launched Brave
  3. opened Developer Tools -> Network
  4. clicked on Preserve log
  5. copied and pasted https://www.youtube.com/watch?v=dQw4w9WgXcQ&si=YjziZuccJeIE-b6z into the URL bar and hit return
  6. looked at the network requests

Confirmed the 200 OK request dropped the &si= parameter

Screenshot 2024-01-08 at 11 46 44 AM

Case 2: https://youtu.be/watch?v=dQw4w9WgXcQ&si=YjziZuccJeIE-b6z - PASSED

  1. installed 1.63.101
  2. launched Brave
  3. opened Developer Tools -> Network
  4. clicked on Preserve log
  5. copied and pasted https://youtu.be/watch?v=dQw4w9WgXcQ&si=YjziZuccJeIE-b6z into the URL bar and hit return
  6. looked at the network requests

Confirmed the 200 OK request did NOT have the &si= parameter

Screenshot 2024-01-08 at 12 14 45 PM

Case 3: https://www.instagram.com/p/C1nNxSbsAzk/?utm_source=ig_web_button_share_sheet&igsh=ZDNl...IxNw== - PASSED

  1. installed 1.63.101
  2. launched Brave
  3. opened Developer Tools -> Network
  4. clicked on Preserve log
  5. copied and pasted https://www.instagram.com/p/C1nNxSbsAzk/?utm_source=ig_web_button_share_sheet&igsh=ZDNl...IxNw== into the URL bar and hit return
  6. looked at the network requests

Confirmed &igsh=ZDNl...IxNw== only shows up on the 200 Internal Redirect request, NOT on the 200 OK request

example example example
Screenshot 2024-01-08 at 12 01 57 PM Screenshot 2024-01-08 at 12 04 26 PM Screenshot 2024-01-08 at 12 04 35 PM

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 7, 2024
@hffvld
Copy link
Contributor

hffvld commented Feb 7, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP11.231215.009 release-keys
Brave build: 1.63.146
Chromium: 121.0.6167.139 (Official Build) beta (64-bit) 

STEPS:

  1. Install and launch Brave
  2. Go to Instagram and log in to your test account
  3. Tap the Three-dot button on any post > Share to > Copy link
  4. Open NTP > Paste > Confirm that Igsh param is there
  5. Tap Enter > Verify the URL when a page is loaded
  6. Go to YT > Ope any video > Share > Copy URL
  7. Open NTP > Paste > Confirm that the si param is there
  8. Tap Enter > Verify the URL when a page is loaded

ACTUAL RESULTS:

  • Verified that the igsh param is removed when copying Instagram links with Share to > Copy link
  • Verified that the si param is removed when copying YouTube links

1 2 3 4
1 2 3 4
1 2 3 4

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy/query-filter QA Pass - Android ARM QA Pass-macOS QA/Yes release-notes/include
Projects
Status: Completed
Development

No branches or pull requests

4 participants
@fmarier @stephendonner @hffvld and others